Page MenuHomePhabricator
Create Task
Maniphest T230454

Javascript test failures on REL1_31 / REL1_32 / REL1_33
Open, MediumPublic
Actions

Description

Receiving the following test failures:

14:07:53 1 failing
14:07:53 
14:07:53 1) Categories I can view categories:
14:07:53 element (".category-button") still not existing after 10000ms
14:07:53 running chrome
14:07:53 Error: element (".category-button") still not existing after 10000ms
14:07:53     at elements(".category-button") - isExisting.js:46:17
14:07:53     at isExisting(".category-button") - waitForExist.js:67:22
14:07:53 
14:07:53 
14:07:53 npm ERR! code ELIFECYCLE
14:07:53 npm ERR! errno 1
14:07:53 npm ERR! @ selenium-test: `wdio ./tests/selenium/wdio.conf.js`
14:07:53 npm ERR! Exit status 1
14:07:53 npm ERR! 
14:07:53 npm ERR! Failed at the @ selenium-test script.
14:07:53 npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
14:07:53 
14:07:53 npm ERR! A complete log of this run can be found in:
14:07:53 npm ERR!     /cache/npm/_logs/2019-08-09T19_07_53_384Z-debug.log
14:07:53 INFO:backend.ChromeWebDriver:Terminating ChromeWebDriver
14:07:53 INFO:backend.Xvfb:Terminating Xvfb
14:07:53 INFO:backend.DevWebServer:Terminating DevWebServer

and:

14:03:48 ✖ 1 test failed
14:03:48 
14:03:48 FAILED TESTS:
14:03:48   ve.ce.Surface
14:03:48     ✖ onCopy
14:03:48       HeadlessChrome 73.0.3683 (Linux 0.0.0)
14:03:48     Copy list item: text
14:03:48     Expected: "g
14:03:48     
14:03:48     "
14:03:48     Actual: "g"
14:03:48         at testRunner
<...>
at Object.<anonymous>
<...>
14:03:48         at runTest (node_modules/qunit/qunit/qunit.js:1478:30)
14:03:48         at Test.run (node_modules/qunit/qunit/qunit.js:1464:6)
14:03:48         at node_modules/qunit/qunit/qunit.js:1670:12
14:03:48         at Object.advance (node_modules/qunit/qunit/qunit.js:1116:26)

Noticed for release-quibble-composer-mysql-hhvm-docker (example 1, example 2) when working with a completely unrelated security backport for REL1_31, REL1_32 and REL1_33. I manually merged these since the patch for master tested fine (and the patch was one line of unrelated code for an entirely separate extension.)

Dummy changes to test with:

REL1_31https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MobileFrontend/+/534141/
REL1_32https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MobileFrontend/+/534142/
REL1_33https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MobileFrontend/+/534143/

Related Objects
Search...

Event Timeline

sbassett created this task.Aug 13 2019, 9:48 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 13 2019, 9:48 PM
sbassett renamed this task from Javascript exceptions for release-quibble-composer-mysql-hhvm-docker to Javascript test failures for release-quibble-composer-mysql-hhvm-docker.Aug 13 2019, 9:49 PM
hashar added projects: MobileFrontend, Release-Engineering-Team-TODO (201908).Sep 3 2019, 11:58 AM
hashar subscribed.

That might have been due to T225354: VisualEditor broken on REL1_33: "ConfigException: undefined option: 'EnableBlockNoticeStats'", namely that mediawiki/vendor.git lacks some composer dependencies. CI has been made to only use composer on release branches. Dummy test changes:

REL1_31https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MobileFrontend/+/534141/
REL1_32https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MobileFrontend/+/534142/
REL1_33https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MobileFrontend/+/534143/
hashar renamed this task from Javascript test failures for release-quibble-composer-mysql-hhvm-docker to Javascript test failures on REL1_31 / REL1_32 / REL1_33.Sep 3 2019, 11:59 AM
hashar triaged this task as Medium priority.
hashar updated the task description. (Show Details)
thcipriani edited projects, added Release-Engineering-Team-TODO (201909); removed Release-Engineering-Team-TODO (201908).Sep 3 2019, 4:04 PM
Jdlrobson subscribed.Sep 3 2019, 4:36 PM

Is this test running on minerva? Is the LocalSettings in tests/browser being loaded? Is RunJobs being run during the test? Any screenshots?

Jdlrobson added a project: Web-Team-Backlog (Tracking).Sep 3 2019, 4:37 PM
hashar added a comment.Sep 3 2019, 6:27 PM
In T230454#5462163, @Jdlrobson wrote:

Is this test running on minerva? Is the LocalSettings in tests/browser being loaded? Is RunJobs being run during the test? Any screenshots?

The failures occurred on changes made to MobileFrontend, but yeah the tests might have failed anywhere. I have send dummy patches to all three branches so we can look at some fresh build results.

REL1_31 https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MobileFrontend/+/534141/ as well as REL1_32 https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MobileFrontend/+/534141/ die on a Qunit test:

SUMMARY:
✔ 926 tests completed
✖ 1 test failed

FAILED TESTS:
  ve.ce.Surface
    ✖ onCopy
      HeadlessChrome 73.0.3683 (Linux 0.0.0)
    Copy list item: text
    Expected: "g
 
    "
    Actual: "g"

Which I guess is an issue with VisualEditor.

The REL1_33 change fails on a MinervaNeue selenium test, https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MobileFrontend/+/534143/

1) Categories I can view categories:
00:05:21.346 [chrome #0-9] element (".category-button") still not existing after 10000ms
Jdlrobson added a comment.EditedSep 3 2019, 6:52 PM

Looking at that test the step "iAmInBetaMode" does not seem to be working.

image.png (888×1 px, 41 KB)

That looks like 4191c53b90f is missing: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MobileFrontend/+/534220/

hashar added a comment.EditedSep 4 2019, 12:40 PM

REL1_33 works now.

For REL1_31 / REL1_32, the VisualEditor failure looks like T182626: VisualEditor karma test fails on Firefox v52 which I have reopened.

hashar added a subtask: T182626: VisualEditor karma test fails on Firefox v52.Sep 4 2019, 12:55 PM
Jdforrester-WMF edited projects, added Release-Engineering-Team-TODO (201910); removed Release-Engineering-Team-TODO (201909).Oct 2 2019, 5:16 PM
Jdforrester-WMF edited projects, added Release-Engineering-Team-TODO (201911); removed Release-Engineering-Team-TODO (201910).Nov 6 2019, 4:24 PM
Jdforrester-WMF edited projects, added Release-Engineering-Team-TODO (201912); removed Release-Engineering-Team-TODO (201911).Dec 2 2019, 7:30 PM
thcipriani edited projects, added Release-Engineering-Team-TODO; removed Release-Engineering-Team-TODO (201912).Jan 7 2020, 7:08 PM
thcipriani moved this task from Should be empty (use Release-Engineering-Team) to Blocked externally on the Release-Engineering-Team-TODO board.
Jdforrester-WMF closed subtask T182626: VisualEditor karma test fails on Firefox v52 as Resolved.Feb 6 2020, 10:35 PM
Jdforrester-WMF removed a project: Continuous-Integration-Infrastructure.Jun 25 2020, 5:04 PM
hashar added a project: ci-test-error.Jun 26 2020, 3:21 PM
Jdlrobson moved this task from Backlog to 3rd party and developer support on the MobileFrontend board.Jul 24 2020, 2:48 AM
thcipriani removed a project: Release-Engineering-Team (CI & Testing services).Apr 20 2021, 1:09 AM
thcipriani edited projects, added Release-Engineering-Team (Radar); removed Release-Engineering-Team-TODO.Apr 20 2021, 3:26 AM
thcipriani moved this task from Limbo to Blocked on the Release-Engineering-Team (Radar) board.Apr 20 2021, 3:27 AM
Jdlrobson removed a project: Web-Team-Backlog (Tracking).Sep 8 2021, 3:34 PM

Did this get fixed?

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL