Page MenuHomePhabricator
Create Task
Maniphest T230481

Daily browser tests hitting edit rate limits on beta Wikidata
Closed, ResolvedPublic
Actions

Description

Daily browser tests targeting beta are failing on simple wbeditentity calls for creating items, e.g. id = browser.call( () => WikibaseApi.createItem() );. Upon further inspection it seems that they are hitting edit rate limits on wikidata.beta.wmflabs.org.

Log with failing tests: https://integration.wikimedia.org/ci/job/selenium-daily-beta-Wikibase/357/console
"Selenium user" (used for browser tests exclusively) logging in under a non-whitelisted IP: https://logstash-beta.wmflabs.org/app/kibana#/doc/logstash-*/logstash-2019.08.13/mediawiki?id=AWyKznnNeTItmKeUUnT7&_g=()
Edit limit hit for the same IP at the same time: https://logstash-beta.wmflabs.org/app/kibana#/doc/logstash-*/logstash-2019.08.13/mediawiki?id=AWyKz6NPeTItmKeUUnkQ
Currently whitelisted IPs: https://github.com/wikimedia/operations-mediawiki-config/blob/master/wmf-config/InitialiseSettings-labs.php#L570-L577

Details

SubjectRepoBranchLines +/-
Whitelist jenkins for edit rate limits on betaoperations/mediawiki-configmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Jakob_WMDE created this task.Aug 14 2019, 1:46 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 14 2019, 1:46 PM
Jakob_WMDE updated the task description. (Show Details)Aug 14 2019, 1:46 PM
Jakob_WMDE updated the task description. (Show Details)
gerritbot added a comment.Aug 14 2019, 1:48 PM

Change 530144 had a related patch set uploaded (by Jakob; owner: Jakob):
[operations/mediawiki-config@master] Whitelist jenkins for edit rate limits on beta

https://gerrit.wikimedia.org/r/530144

gerritbot added a project: Patch-For-Review.Aug 14 2019, 1:48 PM
Jakob_WMDE mentioned this in T230341: Termbox browser tests failing on beta in daily selenium jobs.Aug 14 2019, 1:50 PM
noarave mentioned this in T222449: Make existing daily selenium nodejs tests for WikibaseLexeme green again.Aug 15 2019, 10:30 AM
gerritbot added a comment.Aug 28 2019, 11:40 AM

Change 530144 merged by jenkins-bot:
[operations/mediawiki-config@master] Whitelist jenkins for edit rate limits on beta

https://gerrit.wikimedia.org/r/530144

Jakob_WMDE moved this task from Doing to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Aug 28 2019, 11:58 AM

Let's see if this worked!

Jakob_WMDE moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Sep 2 2019, 11:17 AM

I monitored this for the past couple of days. While the daily browser test jobs are sadly not green, they at least no longer fail due to edit rate limits.

• alaa_wmde closed this task as Resolved.Oct 1 2019, 2:16 PM
Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Oct 27 2019, 11:10 PM
DannyS712 removed a project: Patch-For-Review.Nov 18 2019, 11:35 AM
DannyS712 subscribed.

[batch] remove patch for review tag from resolved tasks

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL