Page MenuHomePhabricator

scap update-interwiki-cache failure results in multiple commits
Closed, DeclinedPublic

Description

If you run scap update-interwiki-cache once, enter the wrong password, and then run it again.. it leaves the commit locally behind. On the second run a second commit is created and also pushed to gerrit...

It should clean up after itself when it failed

reedy@deploy1001:/srv/mediawiki-staging$ scap update-interwiki-cache
           ___ ____
         ⎛   ⎛ ,----
          \  //==--'
     _//|,.·//==--'    ____________________________
    _OO≣=-  ︶ ᴹw ⎞_§ ______  ___\ ___\ ,\__ \/ __ \
   (∞)_, )  (     |  ______/__  \/ /__ / /_/ / /_/ /
     ¨--¨|| |- (  / ______\____/ \___/ \__^_/  .__/
         ««_/  «_/ jgs/bd808                /_/

13:58:26 Checking for new runtime errors locally
Username for 'https://gerrit.wikimedia.org': reedy
Password for 'https://reedy@gerrit.wikimedia.org': 
remote: Unauthorized
fatal: Authentication failed for 'https://gerrit.wikimedia.org/r/operations/mediawiki-config/'
13:58:45 Unhandled error:
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/scap/cli.py", line 342, in run
    exit_status = app.main(app.extra_arguments)
  File "/srv/mediawiki-staging/scap/plugins/updateinterwikicache.py", line 22, in main
    return super(UpdateInterwikiCache, self).main(*extra_args)
  File "/usr/lib/python2.7/dist-packages/scap/main.py", line 790, in main
    return super(SyncFile, self).main(*extra_args)
  File "/usr/lib/python2.7/dist-packages/scap/main.py", line 84, in main
    self._before_cluster_sync()
  File "/srv/mediawiki-staging/scap/plugins/updateinterwikicache.py", line 49, in _before_cluster_sync
    'HEAD:refs/for/master%l=Code-Review+2'])
  File "/usr/lib/python2.7/subprocess.py", line 186, in check_call
    raise CalledProcessError(retcode, cmd)
CalledProcessError: Command '['/usr/bin/git', 'push', '-q', 'origin', 'HEAD:refs/for/master%l=Code-Review+2']' returned non-zero exit status 128
13:58:45 update-interwiki-cache failed: <CalledProcessError> Command '['/usr/bin/git', 'push', '-q', 'origin', 'HEAD:refs/for/master%l=Code-Review+2']' returned non-zero exit status 128
reedy@deploy1001:/srv/mediawiki-staging$ scap update-interwiki-cache
           ___ ____
         ⎛   ⎛ ,----
          \  //==--'
     _//|,.·//==--'    ____________________________
    _OO≣=-  ︶ ᴹw ⎞_§ ______  ___\ ___\ ,\__ \/ __ \
   (∞)_, )  (     |  ______/__  \/ /__ / /_/ / /_/ /
     ¨--¨|| |- (  / ______\____/ \___/ \__^_/  .__/
         ««_/  «_/ jgs/bd808                /_/

13:58:50 Checking for new runtime errors locally
Username for 'https://gerrit.wikimedia.org': reedy
Password for 'https://reedy@gerrit.wikimedia.org': 
remote: Processing changes: new: 2, done    
remote: 
remote: New Changes:
remote:   https://gerrit.wikimedia.org/r/#/c/operations/mediawiki-config/+/530149 Update interwiki cache
remote:   https://gerrit.wikimedia.org/r/#/c/operations/mediawiki-config/+/530150 Update interwiki cache
remote: 
Has your change merged yet? [y/N]:
[15:59:07] <wikibugs> (PS1) Reedy: Update interwiki cache [mediawiki-config] - https://gerrit.wikimedia.org/r/530149
[15:59:09] <wikibugs> (CR) Reedy: [C: +2] Update interwiki cache [mediawiki-config] - https://gerrit.wikimedia.org/r/530149 (owner: Reedy)
[15:59:13] <wikibugs> (PS1) Reedy: Update interwiki cache [mediawiki-config] - https://gerrit.wikimedia.org/r/530150
[15:59:15] <wikibugs> (CR) Reedy: [C: +2] Update interwiki cache [mediawiki-config] - https://gerrit.wikimedia.org/r/530150 (owner: Reedy)
[15:59:50] <wikibugs> (Abandoned) Reedy: Update interwiki cache [mediawiki-config] - https://gerrit.wikimedia.org/r/530150 (owner: Reedy)

Event Timeline

dancy subscribed.

scap update-interwiki-cache does not attempt to perform git commits as of https://gerrit.wikimedia.org/r/c/mediawiki/tools/scap/+/757062