img_auth.php broken in branches: Exception when wfImageAuthMain tries to call HTTPFileStreamer::preprocessHeaders
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	TomH72
	Aug 15 2019, 10:27 AM

Description

It seems img_auth.php has been broken in the REL1_31, REL1_32 and REL1_33 branches because https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/496705/ has been merged to them without also merging https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/505351/ that it relies on.

So any time wfImageAuthMain tries to call HTTPFileStreamer::preprocessHeaders an exception is thrown as that function does not exist.

Details

	Subject	Repo	Branch	Lines +/-
	Add missing helper for HTTPFileStreamer header syntax	mediawiki/core	REL1_32	+57 -0
	Add missing helper for HTTPFileStreamer header syntax	mediawiki/core	REL1_33	+57 -0

Customize query in gerrit

Event Timeline

TomH72 created this task.Aug 15 2019, 10:27 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 15 2019, 10:27 AM

Aklapper renamed this task from img_auth.php broken in REL1_31, REL1_32 and REL1_33 branches to img_auth.php broken in branches: Exception when wfImageAuthMain tries to call HTTPFileStreamer::preprocessHeaders.Aug 15 2019, 10:49 AM

Aklapper added projects: MediaWiki-General, Regression.

Aklapper added a subscriber: Tgr.

• kchapman added a project: Platform Team Workboards (Clinic Duty Team).Aug 15 2019, 2:10 PM

• kchapman triaged this task as High priority.Aug 19 2019, 5:19 PM

• kchapman moved this task from Inbox to Ready (WIP:5) on the Platform Team Workboards (Clinic Duty Team) board.

daniel added projects: MW-1.31-release, MW-1.32-release, MW-1.33-release.Aug 19 2019, 5:20 PM

Change 529442 had a related patch set uploaded (by Daniel Kinzler; owner: Gergő Tisza):
[mediawiki/core@REL1_31] Add helper for HTTPFileStreamer header syntax

https://gerrit.wikimedia.org/r/529442

Change 531476 had a related patch set uploaded (by Daniel Kinzler; owner: Gergő Tisza):
[mediawiki/core@REL1_32] Add missing helper for HTTPFileStreamer header syntax

https://gerrit.wikimedia.org/r/531476

Change 531477 had a related patch set uploaded (by Daniel Kinzler; owner: Gergő Tisza):
[mediawiki/core@REL1_33] Add missing helper for HTTPFileStreamer header syntax

https://gerrit.wikimedia.org/r/531477

daniel claimed this task.Aug 21 2019, 12:19 PM

daniel moved this task from Ready (WIP:5) to Doing(WIP:5) on the Platform Team Workboards (Clinic Duty Team) board.

I have backported the missing patch to the release branches.
Now we still need new releases to be made...

Change 531477 merged by jenkins-bot:
[mediawiki/core@REL1_33] Add missing helper for HTTPFileStreamer header syntax

https://gerrit.wikimedia.org/r/531477

Change 531476 merged by jenkins-bot:
[mediawiki/core@REL1_32] Add missing helper for HTTPFileStreamer header syntax

https://gerrit.wikimedia.org/r/531476

ReleaseTaggerBot added projects: MW-1.33-notes, MW-1.32-notes.Aug 21 2019, 3:00 PM

daniel moved this task from Waiting for deployment to Doing(WIP:5) on the Platform Team Workboards (Clinic Duty Team) board.Aug 21 2019, 4:06 PM

daniel moved this task from Doing(WIP:5) to Waiting for deployment on the Platform Team Workboards (Clinic Duty Team) board.Aug 23 2019, 3:22 PM

daniel moved this task from Waiting for deployment to Done on the Platform Team Workboards (Clinic Duty Team) board.Oct 8 2019, 9:38 AM

Marking as Resolved as it is in the Done column. Feel free to reopen if there is remaining work.

img_auth.php broken in branches: Exception when wfImageAuthMain tries to call HTTPFileStreamer::preprocessHeadersClosed, ResolvedPublicActions

Description

Details

Event Timeline

img_auth.php broken in branches: Exception when wfImageAuthMain tries to call HTTPFileStreamer::preprocessHeaders
Closed, ResolvedPublic
Actions