| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| VisualEditorOverlay: Fix flickering on load | mediawiki/extensions/MobileFrontend | master | +35 -20 |
Details
Details
Related Objects
Related Objects
- Mentioned In
- T232134: Flickering when opening mobile VE
T230237: Scroll animation when loading the visual editor no longer scrolls to the right place - Mentioned Here
- rEMFRc7482167106a: mobile.init/editor: Simplify some loading code
rEVED9bc03837332b: Debounce calls to 'adjustContentPadding'
T228159: Improve loading progress appearance when loading MF, or switching from MF to VE
T230237: Scroll animation when loading the visual editor no longer scrolls to the right place
Event Timeline
Comment Actions
I tested again on master and I can reproduce it when looking more closely. It doesn't quite go blank, but the read mode content flashes for a few frames, which is definitely poor. Rummana also noticed it when testing T230237.
After my patches for T228159, the page indeed goes blank instead of showing read mode content. Possibly you were testing that?
Comment Actions
This is because in VisualEditorOverlay, we initialize the target after the parent show() method is called – so the overlay is shown with no content first, and then the surface etc. is created. But we can't easily do it in the opposite order, because as part of the initialization, the target measures the toolbar and adjusts the surface based on it, so it has to already be visible. I actually did that in my patches and you noticed the bug it caused:
Comment Actions
Still frames from the video in T230552#5433068:
 |  |  |  |
Frames 2 and 3 should not be here.
I explained what causes frame 2 earlier: T230552#5433079
In frame 3 the content is covered by the toolbar. Maybe that's caused by rEVED9bc03837332b: Debounce calls to 'adjustContentPadding'?
Comment Actions
Change 534880 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/MobileFrontend@master] VisualEditorOverlay: Fix flickering on load
Comment Actions
For the record, I git-bisected and found that I apparently caused this issue in rEMFRc7482167106a: mobile.init/editor: Simplify some loading code. I don't really understand how that change causes it though, and it would be difficult to revert since changes for T228159 depended on that. I like the new solution more.
Comment Actions
Change 534880 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] VisualEditorOverlay: Fix flickering on load