Page MenuHomePhabricator

In the Georgian Wikipedia, adding links in VisualEditor is broken because of incorrect capitalization
Open, HighPublic

Description

This issue has a similar reason to T208139, but it's distinct.

The Georgian alphabet has problematic rules with automatic capitalization. Various pieces of software handle capitalization of this alphabet in unexpected ways.

Because of this, adding links in Visual Editor doesn't work as it should.

To reproduce:

  1. Create a page in ka.wikipedia.org (Georgian Wikipedia).
  2. Edit the page in VE.
  3. Write the text თბილისი (this is the name "Tbilisi", capital of Georgia).
  4. Select this whole word and add a link using it.
  5. Click the first autocompletion suggestion.
  6. Click "რედაქტირება" (Done).

Expected result: Blue link pointing to the article თბილისი.

Actual result: Red link.

The reason is that at some point, the first letter is auto-capitalized. Depending on the device that you are using, it either appear the same as "თბილისი", or the first letter may appear as a square.

This autocapitalization must not be applied here.

Event Timeline

Amire80 created this task.Aug 15 2019, 2:12 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 15 2019, 2:12 PM

Turns out I fixed this in May by re-running the upper case mapping script, but it hasn't been merged yet.

Change 507793 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/core@master] Update phpCharToUpper.json based on current differences

https://gerrit.wikimedia.org/r/507793

Jdlrobson added subscribers: ovasileva, Jdlrobson.

@ovasileva if we want to fix T230810 we should see how we can help with this.

@ovasileva if we want to fix T230810 we should see how we can help with this.

sounds good - putting it on the board so we can analyze them together

phuedx added a subscriber: phuedx.Wed, Aug 28, 5:17 PM
ovasileva triaged this task as High priority.Fri, Aug 30, 3:40 PM

There's no https://ka.wikipedia.beta.wmflabs.org/ so not sure how to test this in the beta cluster.

This works however if I do https://en.wikipedia.beta.wmflabs.org/wiki/%E1%83%97%E1%83%91%E1%83%98%E1%83%9A%E1%83%98%E1%83%A1%E1%83%98_2?uselang=ka so does that mean this is fixed?

ppelberg added a subscriber: ppelberg.

Just talked with @ovasileva: Editing-team is going to QA this bug.

Edtadros reassigned this task from Edtadros to ovasileva.Mon, Sep 16, 2:08 PM
Edtadros added a subscriber: Edtadros.

@ovasileva do you still want me to QA this? I'm being extra cautious because it has to be done in production.

Per T230559#5491229 untagging. Olga please bring it back to the sprint board if you need input from @Edtadros too

I've just tested in production in the Georgian Wikipedia, and it appears to be fixed, but I asked person who knows the language and told me about the bug at Wikimania to test more thoroughly.

I've just tested in production in the Georgian Wikipedia, and it appears to be fixed, but I asked person who knows the language and told me about the bug at Wikimania to test more thoroughly.

... And he quickly confirmed that it's fixed.

Thanks to everyone, I tested and everything works :)