Page MenuHomePhabricator

Special:HideBanners renders as a blank page
Closed, InvalidPublic

Description

Steps to reproduce:
Go to https://en.wikipedia.org/wiki/Special:HideBanners

Output:
Blank web page. Absolutely no HTML elements or alerts in the javascript console

Expected result:
Something is shown

Event Timeline

Restricted Application added a subscriber: • Aklapper. · View Herald Transcript

Thanks for the report, @DannyS712. Wikimedia Fundraising uses this page in a very particular way - we source it as an image from the donation Thank You page (hosted on donate.wikimedia.org) so we can set a cookie on the wikipedia.org domain that we check to hide fundraising banners for about a year. So the page actually should render as a minimal image, and set a cookie depending on the querystring parameters.

Steps to reproduce:
Go to https://en.wikipedia.org/wiki/Special:HideBanners

Output:
Blank web page. Absolutely no HTML elements or alerts in the javascript console

Expected result:
Something is shown

Hi @DannyS712! Thanks for the feedback! As @Ejegg explained, this page is worked as expected. As this is an unlisted special page, there shouldn't be any links to it from anywhere, so it shouldn't matter that there's no content for a user who views it directly.

I'd like to close this bug as invalid. Do you have any objections? Then, if you have any specific suggestions for a better mechanism for setting cookies to hide banners across all WMF wikis, you could open a new task for that. Sound good?

Thanks again!!

Even better than cookies would be a way to set the banner-hide keys in localStorage (so browsers don't send data unnecessarily on every request). Though that implies JS running in the context of a different domain - iframes, I guess?

Even better than cookies would be a way to set the banner-hide keys in localStorage (so browsers don't send data unnecessarily on every request). Though that implies JS running in the context of a different domain - iframes, I guess?

Hmmm I dunno... This is already tracked in T117433, BTW. Since I don't think the issue is that there's a blank special page, I'd say we still close this bug, no?

Oh yeah, just going off on a tangent. This bug report describes the intended behavior of the special page.

Oh yeah, just going off on a tangent. This bug report describes the intended behavior of the special page.

I'm sorry, are you saying that it is intended to show absolutely nothing? Not even a help or back to main page or anything link?

Oh yeah, just going off on a tangent. This bug report describes the intended behavior of the special page.

I'm sorry, are you saying that it is intended to show absolutely nothing? Not even a help or back to main page or anything link?

Correct. It's not meant for users ever to visit this page. It's accessed only via background requests from CentralNotice client-side code. Adding any content would needlessly degrade performance for users, since it would needlessly use bandwidth. No links are ever shown for users to go to this page, so it's fine. If you'd like to suggest a better mechanism for setting hide cookies, though, please don't hesitate to comment on T117433.

Thanks so much!!