Page MenuHomePhabricator
Create Task
Maniphest T230591

Abuse filter edit field is too narrow, especially if user cannot edit
Closed, ResolvedPublic
Actions

Description

Steps to reproduce:
View an abuse filter, such as https://en.wikipedia.org/wiki/Special:AbuseFilter/1

Result:

Abuse Filter narrow.JPG (1×2 px, 128 KB)

Expected result:
The abuse filter isn't as narrow

Details

SubjectRepoBranchLines +/-
Restyle edit box dimensionsmediawiki/extensions/AbuseFiltermaster+27 -19
Customize query in gerrit

Event Timeline

DannyS712 created this task.Aug 16 2019, 12:31 AM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptAug 16 2019, 12:31 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DannyS712 moved this task from Unsorted to Abuse Filter on the User-DannyS712 board.Aug 16 2019, 6:06 AM
Daimona renamed this task from Abuse filters rendering at half width to Abuse filter edit field is too narrow, especially if user cannot edit.Aug 17 2019, 4:06 PM

Note that the link you posted refers to a filter that you cannot edit, and thus you get reduced size. If you can edit the filter, it appears wider, although that's still narrower than I'd like to see it.

gerritbot added a comment.Aug 17 2019, 4:54 PM

Change 530700 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Restyle edit box dimensions

https://gerrit.wikimedia.org/r/530700

gerritbot added a project: Patch-For-Review.Aug 17 2019, 4:54 PM
Daimona claimed this task.Aug 17 2019, 4:55 PM
gerritbot added a comment.Aug 20 2019, 4:33 PM

Change 530700 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Restyle edit box dimensions

https://gerrit.wikimedia.org/r/530700

Maintenance_bot removed a project: Patch-For-Review.Aug 20 2019, 5:10 PM
ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.20; 2019-08-27).Aug 21 2019, 12:01 AM
Daimona closed this task as Resolved.Aug 21 2019, 2:52 PM
DannyS712 reopened this task as Open.Aug 27 2019, 5:12 AM

@Daimona for me this is still a problem on some filters, such as https://en.wikipedia.org/wiki/Special:AbuseFilter/978 (screenshot below, its a private filter so I hid the content)

Abuse Filter narrow 2.JPG (1×2 px, 120 KB)

Daimona closed this task as Resolved.Aug 27 2019, 8:19 AM

The patch still has to reach production, see https://www.mediawiki.org/wiki/MediaWiki_1.34/Roadmap and compare with the tag added at T230591#5426576.

DannyS712 added a comment.Aug 27 2019, 8:21 AM
In T230591#5440298, @Daimona wrote:

The patch still has to reach production, see https://www.mediawiki.org/wiki/MediaWiki_1.34/Roadmap and compare with the tag added at T230591#5426576.

Sorry, my mistake

DannyS712 moved this task from Abuse Filter to Resolved tasks (Abuse Filter) on the User-DannyS712 board.Sep 24 2019, 5:39 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL