Page MenuHomePhabricator

In beta audio player (VideoJS), line breaks in TimedText are not recognized
Closed, ResolvedPublic

Description

Today I created this TimedText page. In the old player, at 14.75 seconds the caption has a <br> inserted where there is a line break in the TimedText file, but in the beta player the line break is displayed as a normal space due to not being converted to a <br>.

To fix this, presumably either the line breaks would have to be converted automatically, or CSS like .caption-cue { white-space: pre-line; } would have to be added.

Event Timeline

Jc86035 created this task.Sat, Aug 17, 10:53 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSat, Aug 17, 10:53 AM
Jc86035 updated the task description. (Show Details)Sat, Aug 17, 10:58 AM
Jc86035 updated the task description. (Show Details)Sat, Aug 17, 12:55 PM
Jc86035 renamed this task from In beta video player (VideoJS), line breaks in TimedText are not recognized to In beta audio player (VideoJS), line breaks in TimedText are not recognized.Sat, Aug 17, 1:11 PM
TheDJ claimed this task.Sat, Aug 17, 6:57 PM

Change 531431 had a related patch set uploaded (by Jc86035; owner: Jc86035):
[mediawiki/extensions/TimedMediaHandler@master] Display line breaks in VideoJS audio player captions

https://gerrit.wikimedia.org/r/531431

Change 531431 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] Display line breaks in VideoJS audio player captions

https://gerrit.wikimedia.org/r/531431

TheDJ closed this task as Resolved.Thu, Aug 22, 7:55 AM
TheDJ reassigned this task from TheDJ to Jc86035.
TheDJ added a subscriber: TheDJ.