Minerva styles the wrong selector for rollback link
Closed, ResolvedPublicBUG REPORT
Actions

Description

Notice how it's different to undo, with the box around it.

Developer notes

The selector in the Minerva skin style is wrong.

Qa steps

Visit https://en.m.wikipedia.beta.wmflabs.org/wiki/Spain?action=history and confirm there is no styling issues with the rollback link.

Details

	Subject	Repo	Branch	Lines +/-
	Correct CSS selector for rollback link	mediawiki/skins/MinervaNeue	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: rSKIN4e4bd5e5c34c: Update git submodules

Event Timeline

Krenair created this task.Aug 17 2019, 1:46 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 17 2019, 1:46 PM

Ammarpad added a project: Advanced Mobile Contributions.Aug 17 2019, 4:00 PM

pmiazga added a project: Web-Team-Backlog.Aug 19 2019, 9:25 PM

Jdlrobson renamed this task from Mobile styling of HistoryAction mishandles rollback link to Minerva styles the wrong selector for rollback link.Aug 19 2019, 9:48 PM

Jdlrobson updated the task description. (Show Details)

Change 530975 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Correct CSS selector for rollback link

https://gerrit.wikimedia.org/r/530975

gerritbot added a project: Patch-For-Review.Aug 19 2019, 9:48 PM

Jdlrobson edited projects, added UI-Standardization, Confirmation prompt for rollback action, Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue; removed Web-Team-Backlog, MobileFrontend.Aug 19 2019, 9:48 PM

Change 530975 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Correct CSS selector for rollback link

https://gerrit.wikimedia.org/r/530975

Restricted Repository Identity mentioned this in rSKIN4e4bd5e5c34c: Update git submodules.Aug 20 2019, 8:48 AM

Maintenance_bot removed a project: Patch-For-Review.Aug 20 2019, 9:10 AM

Jdlrobson assigned this task to Edtadros.Aug 20 2019, 2:45 PM

Jdlrobson moved this task from Needs Analysis to Needs QA on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.

Jdlrobson updated the task description. (Show Details)

ovasileva triaged this task as Medium priority.Aug 20 2019, 3:23 PM

ovasileva reassigned this task from Edtadros to Jdrewniak.Aug 20 2019, 5:08 PM

ovasileva added a subscriber: Edtadros.

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.20; 2019-08-27).Aug 20 2019, 11:01 PM

@Jdrewniak, just following up from the meeting: do you have what you need to QA?

@Niedzielski 👍

Per AQ steps: this looks good on beta.

Jdrewniak removed Jdrewniak as the assignee of this task.Aug 26 2019, 10:55 PM

Jdrewniak moved this task from Needs QA to Ready for Signoff on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.

Jdrewniak subscribed.

Looks good

	F30045018: image.png
	Aug 17 2019, 1:46 PM

Minerva styles the wrong selector for rollback linkClosed, ResolvedPublicBUG REPORTActions