@coversDefaultClass should be allowed on traits as well as classes (MediaWiki.Commenting.PhpunitAnnotations.NotClass)
Closed, DeclinedPublicBUG REPORT
Actions

Assigned To

None

Authored By

	Simetrical
	Aug 18 2019, 1:01 PM

Description

@coversDefaultClass seems to work fine on a trait as well as a class, but I get this error:

----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 13 | WARNING | The phpunit annotation @coversDefaultClass should
    |         | only be used in class level comments.
    |         | (MediaWiki.Commenting.PhpunitAnnotations.NotClass)
----------------------------------------------------------------------

I tried poking a little at the code for our sniff rules but didn't know how to fix the problem.

Event Timeline

Simetrical created this task.Aug 18 2019, 1:01 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 18 2019, 1:01 PM

Also @covers and presumably other things.

Actually, @covers might not actually work on trait-level comments (PHPUnit bug?).

For the record, @coversDefaultClass seems not to work properly on HHVM either, although on PHP I didn't get any errors. So maybe the sniff is a good idea, at least for now.

HHVM was using an older version of phpunit, so it may be fixed in the newer one (phpunit 6 or later).

@Simetrical is this still needed? If so can you provide an example patch that fails but should pass?

Umherirrender unsubscribed.Feb 27 2021, 12:27 PM

Per lack of response above, does not appear needed

@coversDefaultClass should be allowed on traits as well as classes (MediaWiki.Commenting.PhpunitAnnotations.NotClass)Closed, DeclinedPublicBUG REPORTActions

Description

Event Timeline

@coversDefaultClass should be allowed on traits as well as classes (MediaWiki.Commenting.PhpunitAnnotations.NotClass)
Closed, DeclinedPublicBUG REPORT
Actions