Page MenuHomePhabricator

Contribution Recur records created via updonate should attach to original contact
Closed, ResolvedPublic2 Estimated Story Points

Description

Was: Where's my upsell donation?

I tested the upsell link on August 16th but I don't see my donation in the system. Can you pls check?

Current state of updonate is to create a second contact record for the recurring contribution, and rely on dedupe to merge them later. This leaves people confused when looking for them, and ends up with a lot more DB load due to a merge than it would take to look up the matching donor in the first place.

Event Timeline

On the Contributions tab, try clicking the 'Recurring Contributions' link at the top. For the contact using your Yahoo email address, I do see a $2 recurring contribution with a start date of September 17th 2019 (at 12:51 AM UTC).

We send the recurring contribution message to Civi totally separate from the initial contribution message, so we don't miss sending the initial one in case the donor just closes their browser when they see the upsell. That means that we're creating a new contact record for the recurring contribution, then later merging it into the existing contact record. So when you were first looking for the recurring contribution, it may not have been merged yet.

I think we could use the contribution tracking ID to avoid the duplicate contact record - I'll look into that.

Change 531017 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/crm@master] Recurring consumer looks up contact via ct_id

https://gerrit.wikimedia.org/r/531017

Ejegg renamed this task from Where's my upsell donation? to Contribution Recur records created via updonate should attach to original contact.Aug 21 2019, 2:32 AM
Ejegg claimed this task.
Ejegg triaged this task as Medium priority.
Ejegg updated the task description. (Show Details)
Ejegg set the point value for this task to 2.

Change 531017 merged by jenkins-bot:
[wikimedia/fundraising/crm@master] Recurring consumer looks up contact via ct_id

https://gerrit.wikimedia.org/r/531017

@Ejegg this maybe goes to the deployed column now?