The parser should keep a list of variadic functions, and strictly check the amount of parameters for the other functions
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Daimona
	Aug 20 2019, 2:14 PM

Description

Now it only checks that there are enough parameters, so e.g. count() fails. But the upper bound is not checked, so it's also fine to use count('x', 'y', 'lots', 'of', 'unused', 'params'). Note that we'll need a deprecation phase before actually rejecting extra parameters.

Plan (as of 16 Sept.)

Formally deprecated too many params in 1.34
Change it to throw in MW 1.35

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
Really throw for too many params	mediawiki/extensions/AbuseFilter	master	+2 -36
Hard-deprecate too many params	mediawiki/extensions/AbuseFilter	REL1_34	+28 -8
Hard-deprecate too many params	mediawiki/extensions/AbuseFilter	master	+28 -8
Warn if a function has been given too many parameters	mediawiki/extensions/AbuseFilter	master	+164 -60

Customize query in gerrit

Related Objects

Mentioned In: T234058: Review new AbuseFilter hard deprecations ahead of 1.34 release

Event Timeline

Daimona created this task.Aug 20 2019, 2:14 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 20 2019, 2:14 PM

Daimona updated the task description. (Show Details)Aug 20 2019, 2:14 PM

Change 531438 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Throw if a function has been given too many parameters

https://gerrit.wikimedia.org/r/531438

gerritbot added a project: Patch-For-Review.Aug 21 2019, 9:03 AM

Change 531441 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Really throw for too many params

https://gerrit.wikimedia.org/r/531441

Again, we'll have to fix WMF filters before starting to throw.

Daimona added a parent task: T230263: Tasks requiring manual edits of existing abuse filters in production (tracking).Aug 21 2019, 9:08 AM

Daimona moved this task from Backlog to Requiring manual fix of filters in production [SUPERSEDED BY #wikimedia-abusefilter-maintainers] on the AbuseFilter board.Aug 21 2019, 12:19 PM

Daimona removed a parent task: T230263: Tasks requiring manual edits of existing abuse filters in production (tracking).

Change 531438 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Warn if a function has been given too many parameters

https://gerrit.wikimedia.org/r/531438

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.20; 2019-08-27).Aug 27 2019, 12:01 AM

No affected filters in production.

Daimona updated the task description. (Show Details)Sep 16 2019, 1:56 PM

Change 537116 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Hard-deprecate too many params

https://gerrit.wikimedia.org/r/537116

The deprecation should happen in 1.34.

Daimona updated the task description. (Show Details)Sep 27 2019, 3:52 PM

Daimona mentioned this in T234058: Review new AbuseFilter hard deprecations ahead of 1.34 release.Sep 27 2019, 4:15 PM

Erutuon updated the task description. (Show Details)Oct 8 2019, 7:42 PM

Krinkle removed a project: MW-1.34-release.Nov 6 2019, 12:37 AM

Change 537116 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Hard-deprecate too many params

https://gerrit.wikimedia.org/r/537116

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.8; 2019-11-26).Nov 12 2019, 1:00 AM

Nullzero closed this task as Resolved.Nov 12 2019, 6:19 PM

Change 550527 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@REL1_34] Hard-deprecate too many params

https://gerrit.wikimedia.org/r/550527

Daimona reopened this task as Open.Nov 12 2019, 6:36 PM

Daimona updated the task description. (Show Details)

My bad!

Change 550527 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@REL1_34] Hard-deprecate too many params

https://gerrit.wikimedia.org/r/550527

Change 531441 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Really throw for too many params

https://gerrit.wikimedia.org/r/531441

Daimona closed this task as Resolved.Dec 3 2019, 7:21 PM