Migrate documentation generation to Node 10.15.2 from node 6.11.0
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	Aug 20 2019, 11:12 PM

Description

MobileFrontend has documentation that runs using npm run doc that publishes documentation to https://docs.wikimedia.org. It has been failing for a while now.

For some reason this is still using node v6.11.0.

See https://integration.wikimedia.org/ci/job/mwext-npm-doc-publish/1934/console for example failure.

15:29:26 /src/node_modules/jsdoc/lib/jsdoc/fs.js:97
15:29:26     fs.copyFileSync(inFile, path.join(outDir, fileName));
15:29:26        ^
15:29:26 
15:29:26 TypeError: fs.copyFileSync is not a function
15:29:26     at Object.exports.copyFileSync (/src/node_modules/jsdoc/lib/jsdoc/fs.js:97:8)
15:29:26     at staticFiles.forEach.fileName (/src/node_modules/jsdoc/templates/default/publish.js:506:12)

Details

	Project	Branch	Lines +/-	Subject
	integration/config	master	+1 -5	layout: [MobileFrontend] Drop mwext-npm-doc-publish, using extension-javascript-documentation now
	integration/config	master	+1 -5	layout: [MinervaNeue] Drop mwext-npm-doc-publish, using extension-javascript-documentation now

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Stalled	None	T302086 Set scap minimum python version to 3.7
Open	None	T247045 Migrate all of production metal and VMs to Buster or later
Resolved	akosiaris	T249724 Track and remove jessie based container images from production
Resolved	Jdforrester-WMF	T224908 Drop jessie testing support
Resolved	Jdforrester-WMF	T224907 Drop php55 testing support
Resolved	Reedy	T205039 Release MediaWiki 1.27.6/1.30.2/1.31.2/1.32.2
Resolved	Reedy	T205041 Tracking bug for 1.27.6/1.30.2/1.31.2/1.32.2 security release
Resolved	Bawolff	T197279 Direct POST to Special:ChangeEmail will bypass reauth check
Resolved	Anomie	T204729 Potential enwiki DOS due to slow WatchedItemStore::countVisitingWatchersMultiple
Resolved	Bawolff	T207603 CVE-2019-12471: Loading JS from user space where the username is not a registered account is dangerous and should be banned
Resolved	Bawolff	T208881 CSS using var() to create exponential sized calc() on wiki page will crash visitor's browser
Resolved	Legoktm	T199540 Forbid blocking IP ranges as big as /1 and /2, as done on ruwikiquote using the API
Resolved	Lucas_Werkmeister_WMDE	T212118 API responses for unpatrolled or (not) autopatrolled recent changes require privileges but may be cached publicly
Resolved	Bawolff	T209794 Need to make a limit of count of attempts to change email address
Resolved	sbassett	T222036 Exposed suppressed username or log in Special:EditTags
Resolved	sbassett	T222038 Exposed suppressed log in RevisionDelete page
Resolved	Jdforrester-WMF	T221739 Patch jQuery due to CVE-2019-11358
Resolved	sbassett	T25227 Use token when logging out
Resolved	sbassett	T221868 Send out wikitech-l post for T25227 ("Use token when logging out")
Resolved	Reedy	T205042 Write and send release announcements for 1.27.6/1.30.2/1.31.2/1.32.2 security releases
Resolved	Reedy	T205043 Write and send pre-release Announcements for MediaWiki 1.27.6/1.30.2/1.31.2/1.32.2
Resolved	Jdforrester-WMF	T205044 Update onwiki release notes for 1.27.6/1.30.2/1.31.2/1.32.2
Resolved	Reedy	T205046 Update HISTORY in master after 1.27.6/1.30.2/1.31.2/1.32.2
Resolved	Reedy	T205047 Tag MW 1.27.6/1.30.2/1.31.2/1.32.2
Resolved	Reedy	T224499 RELEASE-NOTES for 1.27.6/1.30.2/1.31.2/1.32.2
Resolved	Jdforrester-WMF	T224912 Update MediaWiki.org links and versions
Resolved	Jdforrester-WMF	T224913 EOL REL1_27 and REL1_30 onwiki
Resolved	Reedy	T225201 Formally announce EOL of MW 1.27 and 1.30
Resolved	Reedy	T225149 Update CVEs and publish them
Resolved	Reedy	T205048 Obtain CVEs for 1.27.6/1.30.2/1.31.2/1.32.2 security releases
Resolved	Jdforrester-WMF	T224906 Drop php56 testing support
Resolved	hashar	T223348 Run wikimedia/fundraising/crm CI jobs on PHP7x, not PHP5x
Resolved	hashar	T210287 Migrate wikimedia-fundraising-civicrm to a Docker container
Resolved	Jdforrester-WMF	T224905 Move wikiba.se tests from php56 to php72
Resolved	hashar	T224591 Migrate contint* hosts to Buster
Declined	MoritzMuehlenhoff	T226236 Upload docker-ce 18.06.3 upstream package for Stretch
Invalid	thcipriani	T239880 Replacement hardware for buster/stretch upgrade of contint1001 and contint2001
Resolved	mmodell	T215458 Convert zuul to use scap
Resolved	hashar	T240551 Remove Zuul Debian package from WMCS instances
Resolved	Joe	T249110 Build and publish a python2 based container to build wheels
Resolved	JMeybohm	T249812 Rebuild helm/helm-diff for buster-wikimedia
Resolved	JMeybohm	T250479 Rebuild helmfile for buster-wikimedia
Duplicate	Dzahn	T210008 upgrade krypton (webserver_misc_apps) to stretch
Declined	Dzahn	T224194 switch webserver_misc_apps to PHP 7.2 (7.1)
Resolved	Jdforrester-WMF	T211784 Upgrade all CI jobs from node6/npm3 to node10/npm6 across all projects
Resolved	Jdforrester-WMF	T230841 Migrate documentation generation to Node 10.15.2 from node 6.11.0

Event Timeline

Jdlrobson created this task.Aug 20 2019, 11:12 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 20 2019, 11:12 PM

Jdlrobson renamed this task from Migration documentation generation to Node 10.15.2 to Migrate documentation generation to Node 10.15.2 from node 6.11.0.Aug 20 2019, 11:13 PM

Jdlrobson updated the task description. (Show Details)

Jdlrobson added projects: MobileFrontend, Continuous-Integration-Config, Readers-Web-Backlog (Tracking).

Jdlrobson added a parent task: T210704: Migrate node-based services in production to node10.Aug 22 2019, 2:17 PM

Jdlrobson updated the task description. (Show Details)

The replacement for the mwext-npm-doc-publish (node 6) job is extension-javascript-documentation (node 10). It uses a slightly different entry point (it looks for your code to be generated into /docs rather than /docs/js) but writes them to the same place on the docs server. Should be simple enough to shift over.

Change 532417 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[integration/config@master] layout: [MobileFrontend] Drop mwext-npm-doc-publish, using extension-javascript-documentation now

https://gerrit.wikimedia.org/r/532417

Change 532418 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[integration/config@master] layout: [MinervaNeue] Drop mwext-npm-doc-publish, using extension-javascript-documentation now

https://gerrit.wikimedia.org/r/532418

Jdforrester-WMF added a parent task: T211784: Upgrade all CI jobs from node6/npm3 to node10/npm6 across all projects.Aug 26 2019, 6:31 PM

Jdforrester-WMF removed a parent task: T210704: Migrate node-based services in production to node10.

@Jdlrobson:

Unfortunately it's not passing in CI:

00:02:07.087 <s> [webpack.Progress] 70% building 641/641 modules 0 active
00:02:07.905 npm ERR! code ELIFECYCLE
00:02:07.906 npm ERR! errno 1
00:02:07.906 npm ERR! @ build-storybook: build-storybook -o docs/ui
00:02:07.906 npm ERR! Exit status 1
00:02:07.907 npm ERR!
00:02:07.907 npm ERR! Failed at the @ build-storybook script.
00:02:07.907 npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

Locally it passes, both with the image used in CI (node10-test:0.5.0) and other obvious images (node10-test-browser, etc.). Investigating.

Change 532418 merged by jenkins-bot:
[integration/config@master] layout: [MinervaNeue] Drop mwext-npm-doc-publish, using extension-javascript-documentation now

https://gerrit.wikimedia.org/r/532418

Change 532417 merged by jenkins-bot:
[integration/config@master] layout: [MobileFrontend] Drop mwext-npm-doc-publish, using extension-javascript-documentation now

https://gerrit.wikimedia.org/r/532417

Maintenance_bot removed a project: Patch-For-Review.Aug 28 2019, 12:10 AM

hurrah!

Migrate documentation generation to Node 10.15.2 from node 6.11.0Closed, ResolvedPublicActions

Description

Details

Related ObjectsSearch...

Event Timeline

Migrate documentation generation to Node 10.15.2 from node 6.11.0
Closed, ResolvedPublic
Actions

Related Objects
Search...