Page MenuHomePhabricator
Create Task
Maniphest T230912

radiobutton should be top aligned relative to multiline label
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Is: In radiobutton list entries with multiline labels, the radio button starts is vertically mid aligned

Should: radiobutton should be top aligned relative to label:

related: T230880 (same with checkboxes)

Related Objects

Event Timeline

Jan_Dittrich created this task.Aug 21 2019, 11:25 AM
Restricted Application added a project: WMDE-FUN-Team. · View Herald TranscriptAug 21 2019, 11:25 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Jan_Dittrich mentioned this in T230880: checkbox should be top aligned relative to multiline label.Aug 21 2019, 11:25 AM
Jan_Dittrich updated the task description. (Show Details)
gabriel-wmde added a project: WMDE-FUN-Sprint-2019-08-05.Aug 21 2019, 4:51 PM
gabriel-wmde moved this task from Todo to Test on the WMDE-FUN-Sprint-2019-08-05 board.Aug 21 2019, 5:23 PM

I had to remove the fixed height of radio elements (they had different heights for the membership type) and have added padding to push the border further away from each other. Please have a look if any element looks off.

PR in https://github.com/wmde/FundraisingFrontend/pull/1613

Jan_Dittrich added a comment.Aug 22 2019, 7:38 AM

Is this life (somewhere) or do I need to run the branch?

tmletzko added a subscriber: tmletzko.Aug 22 2019, 7:44 AM

@Jan_Dittrich if its deployed on test, check https://test-spenden-2.wikimedia.de/?skin=2

Jan_Dittrich added a comment.Aug 27 2019, 2:04 PM

looks like

Jan_Dittrich moved this task from Test to Deploy on the WMDE-FUN-Sprint-2019-08-05 board.Aug 27 2019, 2:05 PM
Tonina_Zhelyazkova_WMDE moved this task from Backlog to Current Sprint on the WMDE-Fundraising-Tech board.Sep 2 2019, 8:51 AM
Tonina_Zhelyazkova_WMDE set the point value for this task to 1.Sep 3 2019, 10:16 AM
kai.nissen closed this task as Resolved.Jan 13 2020, 10:40 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL