Page MenuHomePhabricator
Create Task
Maniphest T230921

Log URL for all failed Termbox requests
Closed, ResolvedPublic
Actions

Description

Some errors, e.g. those caused by the request validation do not contain the URL or request parameters.

Example of a validation error saying a preferred language did not match the regex from the spec, but does not mention what the requested language was: https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-2019.08.21/wikibase-termbox?id=AWyz1kqzZKA7RpiruGOa

Details

SubjectRepoBranchLines +/-
Termbox: improve logging for invalid requestsoperations/deployment-chartsmaster+1 -1
Termbox: improve logging for invalid requestsoperations/deployment-chartsmaster+1 -1
Termbox: improve logging for invalid requestsoperations/deployment-chartsmaster+1 -1
Termbox: improve logging for invalid requestsoperations/deployment-chartsmaster+1 -1
Log URL for requests with unknown languages and entity/rev mismatcheswikibase/termboxmaster+26 -18
Log request URL for invalid requests and technical problemswikibase/termboxmaster+33 -18
Customize query in gerrit

Related Objects

Event Timeline

Jakob_WMDE created this task.Aug 21 2019, 12:52 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 21 2019, 12:52 PM
Jakob_WMDE updated the task description. (Show Details)Aug 21 2019, 12:53 PM
Jakob_WMDE claimed this task.Aug 21 2019, 12:59 PM
Jakob_WMDE updated the task description. (Show Details)
Jakob_WMDE moved this task from To Do to Doing on the Wikibase-Termbox-Iteration-20 board.
gerritbot added a comment.Aug 21 2019, 2:18 PM

Change 531496 had a related patch set uploaded (by Jakob; owner: Jakob):
[wikibase/termbox@master] Log request URL for invalid requests and technical problems

https://gerrit.wikimedia.org/r/531496

gerritbot added a project: Patch-For-Review.Aug 21 2019, 2:18 PM
gerritbot added a comment.Aug 22 2019, 3:08 PM

Change 531496 merged by jenkins-bot:
[wikibase/termbox@master] Log request URL for invalid requests and technical problems

https://gerrit.wikimedia.org/r/531496

Maintenance_bot removed a project: Patch-For-Review.Aug 22 2019, 3:10 PM
Jakob_WMDE mentioned this in rWBTB06cbea67ad20: Log request URL for invalid requests and technical problems.Aug 22 2019, 3:12 PM
gerritbot added a comment.Aug 22 2019, 3:53 PM

Change 531717 had a related patch set uploaded (by Jakob; owner: Jakob):
[wikibase/termbox@master] Log URL for requests with unknown languages and entity/rev mismatches

https://gerrit.wikimedia.org/r/531717

gerritbot added a project: Patch-For-Review.Aug 22 2019, 3:53 PM
gerritbot added a comment.Aug 24 2019, 4:07 AM

Change 531717 merged by jenkins-bot:
[wikibase/termbox@master] Log URL for requests with unknown languages and entity/rev mismatches

https://gerrit.wikimedia.org/r/531717

Maintenance_bot removed a project: Patch-For-Review.Aug 24 2019, 4:10 AM
Jakob_WMDE mentioned this in rWBTB67905bc6f463: Log URL for requests with unknown languages and entity/rev mismatches.Aug 24 2019, 4:13 AM
gerritbot added a comment.Aug 26 2019, 10:28 AM

Change 532351 had a related patch set uploaded (by Jakob; owner: Jakob):
[operations/deployment-charts@master] Termbox: improve logging for invalid requests

https://gerrit.wikimedia.org/r/532351

gerritbot added a project: Patch-For-Review.Aug 26 2019, 10:28 AM

Change 532352 had a related patch set uploaded (by Jakob; owner: Jakob):
[operations/deployment-charts@master] Termbox: improve logging for invalid requests

https://gerrit.wikimedia.org/r/532352

gerritbot added a comment.Aug 26 2019, 10:28 AM

Change 532353 had a related patch set uploaded (by Jakob; owner: Jakob):
[operations/deployment-charts@master] Termbox: improve logging for invalid requests

https://gerrit.wikimedia.org/r/532353

gerritbot added a comment.Aug 26 2019, 10:28 AM

Change 532354 had a related patch set uploaded (by Jakob; owner: Jakob):
[operations/deployment-charts@master] Termbox: improve logging for invalid requests

https://gerrit.wikimedia.org/r/532354

gerritbot added a comment.Aug 26 2019, 1:56 PM

Change 532351 merged by Jakob:
[operations/deployment-charts@master] Termbox: improve logging for invalid requests

https://gerrit.wikimedia.org/r/532351

gerritbot added a comment.Aug 26 2019, 1:59 PM

Change 532352 merged by Jakob:
[operations/deployment-charts@master] Termbox: improve logging for invalid requests

https://gerrit.wikimedia.org/r/532352

gerritbot added a comment.Aug 26 2019, 2:03 PM

Change 532353 merged by Jakob:
[operations/deployment-charts@master] Termbox: improve logging for invalid requests

https://gerrit.wikimedia.org/r/532353

Jakob_WMDE mentioned this in rDEPLOYCHARTSfc1c8d909589: Termbox: improve logging for invalid requests.Aug 26 2019, 2:08 PM
Jakob_WMDE mentioned this in rDEPLOYCHARTSd33a9c262baa: Termbox: improve logging for invalid requests.
Jakob_WMDE mentioned this in rDEPLOYCHARTS1904101c6cbb: Termbox: improve logging for invalid requests.
gerritbot added a comment.Aug 26 2019, 2:15 PM

Change 532354 merged by Jakob:
[operations/deployment-charts@master] Termbox: improve logging for invalid requests

https://gerrit.wikimedia.org/r/532354

Jakob_WMDE mentioned this in rDEPLOYCHARTS40ba5036c9fe: Termbox: improve logging for invalid requests.Aug 26 2019, 2:17 PM
Jakob_WMDE moved this task from Doing to Done on the Wikibase-Termbox-Iteration-20 board.Aug 26 2019, 2:26 PM

This is now deployed! Bad language request: https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-2019.08.26/wikibase-termbox?id=AWzOUDrqCfBFUvHRMov_

Maintenance_bot removed a project: Patch-For-Review.Aug 26 2019, 3:10 PM
Tarrow closed this task as Resolved.Oct 22 2019, 2:21 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL