Page MenuHomePhabricator

RedirectSpecialArticle.php: PHP Notice: Undefined index: action
Closed, ResolvedPublic

Description

Error

Request ID: XV1MkgpAAEEAAHcjL08AAACE
Request URL: /wiki/Special:MyLanguage/Help:Contents?uselang=de

message
[XV1MkgpAAEEAAHcjL08AAACE] /wiki/Special:MyLanguage/Help:Contents?uselang=de   ErrorException from line 120 of /srv/mediawiki/php-1.34.0-wmf.19/includes/specialpage/RedirectSpecialArticle.php: PHP Notice: Undefined index: action
trace
#0 /srv/mediawiki/php-1.34.0-wmf.19/includes/specialpage/RedirectSpecialArticle.php(120): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.34.0-wmf.19/includes/MediaWiki.php(273): RedirectSpecialArticle->getRedirectQuery(string)
#2 /srv/mediawiki/php-1.34.0-wmf.19/includes/MediaWiki.php(892): MediaWiki->performRequest()
#3 /srv/mediawiki/php-1.34.0-wmf.19/includes/MediaWiki.php(523): MediaWiki->main()
#4 /srv/mediawiki/php-1.34.0-wmf.19/index.php(42): MediaWiki->run()
#5 /srv/mediawiki/w/index.php(3): require(string)
#6 {main}
Impact

24 hits in mediawiki-new-errors in the last hour, 44 hits in the last 24 hours, not seen in logs before that.

Notes

Since it's a new error, it's blocking train.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptWed, Aug 21, 2:09 PM
zeljkofilipin triaged this task as Unbreak Now! priority.Wed, Aug 21, 2:09 PM
Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptWed, Aug 21, 2:10 PM

Looks like the only thing in MediaWiki_1.34/wmf.19/Changelog related to RedirectSpecialArticle is 529179. Looks like it was fixed in 530896 but it's not in wmf.19.

cc @matmarex @mobrovac @Krinkle @Jdforrester-WMF

It's probably fine to roll out without the back-port.

Change 531497 had a related patch set uploaded (by Jforrester; owner: Bartosz Dziewoński):
[mediawiki/core@wmf/1.34.0-wmf.19] RedirectSpecialArticle: Fix PHP notice about undefined index

https://gerrit.wikimedia.org/r/531497

It's probably fine to roll out without the back-port.

I did not understand that. 🤔

Change 531497 merged by jenkins-bot:
[mediawiki/core@wmf/1.34.0-wmf.19] RedirectSpecialArticle: Fix PHP notice about undefined index

https://gerrit.wikimedia.org/r/531497

Mentioned in SAL (#wikimedia-operations) [2019-08-21T18:18:55Z] <jforrester@deploy1001> Synchronized php-1.34.0-wmf.19/includes/specialpage/RedirectSpecialPage.php: T230932 RedirectSpecialArticle: Fix PHP notice about undefined index (duration: 00m 54s)

Jdforrester-WMF closed this task as Resolved.Wed, Aug 21, 6:20 PM
Jdforrester-WMF assigned this task to matmarex.

Deployed. Thank you!

mmodell changed the subtype of this task from "Task" to "Production Error".Wed, Aug 28, 11:05 PM