Following up on today's DS-fr tech checkin, there are the three donors @krobinson found whose PayPal contribs seem to be listed twice, as both PayPal and EC transactions:
CID 8916000
CID 12854210
CID 13062353
Thanks for the suggestion to compare Civi with the console, @Ejegg you spared us needing to ask PayPal.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Tag txn_type cart and payment_type instant as EC | wikimedia/fundraising/SmashPig | master | +7 -1 |
@Ejegg Kristie found another more recent example, from Aug 23rd: CID=5897344, PAYPAL_EC 31X68282EH588133Y and PAYPAL 31X68282EH588133Y
12854210 actually did make two contributions, the second three minutes after the first, for the exact same amount. Both are tagged as PayPal EC, but have different transaction IDs
The donation from 8916000 seems not to have come in via payments-wiki. It's got no invoice id and there's no donation in the payments-wiki logs with a matching amount and currency on that day. The contribution tracking record is pretty bare - looks like it was synthesized on donation import and not written from payments-wiki.
13062353 is like 8916000 - no invoice ID, and no clear match in the payments logs. The nearest one with the same amount is an hour an a half later.
5897344 is the same - no invoice ID, closest donations of the same amount in the logs are either 3 hrs earlier or 4 hrs later.
I'd be curious to learn how they made the donations - maybe they saved an old link?
For the past month, about 1 in 10,000 PayPal payments has no invoice ID, so that's certainly not a widespread problem. I think we can update the audit parser to tag anything missing an invoice ID as legacy paypal, since that's what the IPN listener is doing.
Oddly enough, the audit files have the "Payment Source" column as "Express Checkout" for each of the mystery donations. I understood that Express Checkout required us to initiate the payment on our website (which would set an invoice ID and leave a trail in the logs), so I'm a bit confused how they could really be via that integration.
IPN messages don't have a clear payment source. Besides not having an Invoice ID, the other oddity with them is that the transaction_subject is "Donation to Wikimedia Foundation" rather than "Donation to *the* Wikimedia Foundation" (or translated equivalent) as with all the others.
Change 536723 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/SmashPig@master] Tag txn_type cart and payment_type instant as EC
Change 536723 merged by jenkins-bot:
[wikimedia/fundraising/SmashPig@master] Tag txn_type cart and payment_type instant as EC