Page MenuHomePhabricator

CR+2 on MediaWiki for Aryeh Gregor (aka Simetrical)
Closed, ResolvedPublic

Tokens
"Like" token, awarded by aaron."Like" token, awarded by CCicalese_WMF."Like" token, awarded by eranroz."Like" token, awarded by Jdforrester-WMF."Like" token, awarded by Krinkle."Like" token, awarded by Tgr."Like" token, awarded by BPirkle."Like" token, awarded by D3r1ck01."Like" token, awarded by TheDJ."Like" token, awarded by WMDE-leszek."Like" token, awarded by Bawolff."Like" token, awarded by kostajh."Like" token, awarded by Daimona.
Assigned To
Authored By
daniel, Thu, Aug 22

Description

I propose for Aryeh Gregor to be granted the right to approve changes against MediaWiki core and extensions, by adding him to the mediawiki LDAP group in accordance with the privilege policy.

Aryeh has been contributing to MediaWiki on and off for a decade or so, both as a volunteer and a contractor. He joined gerrit only a year ago, but he had commit access already back in the day when MediaWiki was still managed on SVN. In the time I have been working with Aryeh, he has shown excellent skill and good judgement. Granting him merge rights would allow him to contribute not only by writing code, but also by approving changes made by others.

Recent gerrit contributions: https://gerrit.wikimedia.org/r/q/owner:ayg%2540aryeh.name

Event Timeline

daniel created this task.Thu, Aug 22, 9:21 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptThu, Aug 22, 9:21 AM

My older contributions are available via git log --author simetrical. I couldn't find a webpage that would display the results of the search that I could link to. Note that that includes things from the SVN era that I only committed and didn't author, so it's inflated (probably only slightly). But if we leave that aside, according to git shortlog -sne, I have 1052 commits (after updating .mailmap to merge the three different e-mail addresses I've used). Surprisingly, this still makes me the #19 all-time contributor by number of commits. I think I always tended to break up my commits more than a lot of people, though.

I should add that lately I've been contracting for Wikimedia for about seven weeks a year, and have been working 30-40 hours a week during those periods. When not contracting, I'm completely inactive.

Tgr awarded a token.Thu, Aug 22, 10:15 PM

It's been seven days, and seemingly no objections. It would be useful for me to have +2 rights now just to re-submit patches I've written that failed gate-and-submit due to flaky tests or non-substantive reasons ("HHVM doesn't like syntax X"). I seem to have a lot of those, and right now I have to wait for someone else to deal with it.

aaron awarded a token.Fri, Aug 30, 4:26 PM
daniel added a comment.Mon, Sep 2, 2:49 PM

@Simetrical if this hasn't happened by the time you come back, let me know.

Krenair added a subscriber: Krenair.Mon, Sep 2, 6:26 PM

We're just waiting for a Gerrit admin now right?

We're just waiting for a Gerrit admin now right?

group-mediawiki is indeed owned by Administrators but https://gerrit.wikimedia.org/r/#/admin/groups/1,members says we have none but the dummy gerrit account. I guess ldap/gerritadmin people could do it? I'm not sure which system is in place now.

I must also note that the policy as currently written references to https://gerrit.wikimedia.org/r/#/admin/groups/119,members as the group of people able to "resolve the request" (sic), which is not true as Gerrit Managers do not have the ability to add or remove people from mediawiki. Looks like the link has to be changed either to point to https://gerrit.wikimedia.org/r/#/admin/groups/1,members or https://tools.wmflabs.org/ldap/group/gerritadmin (cc. @tstarling ).

daniel added a comment.Tue, Sep 3, 9:18 AM

I must also note that the policy as currently written references to https://gerrit.wikimedia.org/r/#/admin/groups/119,members as the group of people able to "resolve the request" (sic), which is not true as Gerrit Managers do not have the ability to add or remove people from mediawiki. Looks like the link has to be changed either to point to https://gerrit.wikimedia.org/r/#/admin/groups/1,members or https://tools.wmflabs.org/ldap/group/gerritadmin (cc. @tstarling ).

The wording in the policy is overly specific. The intent was to say that these requests can be handled by whoever has the necessary permissions. When we wrote the policy, that was the admin group, but this as since changed. The policy should be amended accordingly.

tstarling closed this task as Resolved.Wed, Sep 4, 12:06 AM
tstarling claimed this task.

There's no mediawiki LDAP group, and the policy does not refer to such a group. I added Aryeh to the mediawiki group in Gerrit.

I must also note that the policy as currently written references to https://gerrit.wikimedia.org/r/#/admin/groups/119,members as the group of people able to "resolve the request" (sic), which is not true as Gerrit Managers do not have the ability to add or remove people from mediawiki. Looks like the link has to be changed either to point to https://gerrit.wikimedia.org/r/#/admin/groups/1,members or https://tools.wmflabs.org/ldap/group/gerritadmin (cc. @tstarling ).

@TheDJ modified the policy from group 1 to group 119 without approval, so that change just needs to be reverted.

TheDJ added a comment.EditedWed, Sep 4, 7:33 AM

If there is a consensus of trusted developers on the Phabricator task, any of the [https://gerrit.wikimedia.org/r/#/admin/groups/1,members Gerrit administrators] can resolve the request.

Of which my point was, that link leads you to 1 administrative email address, not a list of people. And then i got lost by gerrit's permission model trying to correct that question.