Edit summary is blanked when navigating through file importer preview pages
Closed, ResolvedPublic3 Estimated Story PointsBUG REPORT
Actions

Description

Steps to reproduce:

Begin import process
Type into the edit summary
Open "Show changes"
Click "Back to preview"

Your edit summary will have been erased. Other changes to e.g. File Info are persistent.

Other example:

In T230984#5437406, @WMDE-Fisch wrote:

The same also works on commons with the "normal" title change page.

Go to https://commons.wikimedia.beta.wmflabs.org/wiki/Special:ImportFile?clientUrl=https://en.wikipedia.beta.wmflabs.org/wiki/File:Green_Image_Test.png

Type something into the summary

Click on Edit title

Click on Change title

The summary is back to the default ( in that specific case, a prefilled form )

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/FileImporter	master	+22 -8	Pass edit summary through our various forms

Customize query in gerrit

Related Objects

Mentioned In: T232810: Pressing return in the edit summary takes the user to the edit title form
rEFLIbd65c1604f0f: Pass edit summary through our various forms
Mentioned Here: T230984: Cannot import because of interaction between title change and summary field?

Event Timeline

awight created this task.Aug 22 2019, 9:39 AM

Restricted Application added a project: archived--TCB-Team. · View Herald TranscriptAug 22 2019, 9:39 AM

awight changed the subtype of this task from "Task" to "Bug Report".Aug 22 2019, 9:39 AM

Lea_WMDE moved this task from Backlog to Tickets ready for pickup on the Move-Files-To-Commons board.Aug 23 2019, 7:53 AM

Lea_WMDE set the point value for this task to 3.Aug 27 2019, 12:41 PM

Lea_WMDE updated the task description. (Show Details)

Lea_WMDE added a subscriber: WMDE-Fisch.

awight claimed this task.Aug 29 2019, 1:41 PM

awight moved this task from Tickets ready for pickup to Tickets in sprint on the Move-Files-To-Commons board.

awight added a project: WMDE-QWERTY-Sprint-2019-08-21 .

awight moved this task from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2019-08-21 board.

Change 533221 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/extensions/FileImporter@master] [WIP] Pass edit summary through our various forms

https://gerrit.wikimedia.org/r/533221

gerritbot added a project: Patch-For-Review.Aug 29 2019, 2:07 PM

awight moved this task from Doing to Review on the WMDE-QWERTY-Sprint-2019-08-21 board.Aug 30 2019, 9:20 AM

awight moved this task from Review to Demo on the WMDE-QWERTY-Sprint-2019-08-21 board.Sep 2 2019, 12:56 PM

Change 533221 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Pass edit summary through our various forms

https://gerrit.wikimedia.org/r/533221

awight mentioned this in rEFLIbd65c1604f0f: Pass edit summary through our various forms.Sep 2 2019, 1:43 PM

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.21; 2019-09-03).Sep 2 2019, 2:00 PM

Maintenance_bot removed a project: Patch-For-Review.Sep 2 2019, 2:10 PM

Tobi_WMDE_SW added a project: WMDE-QWERTY-Sprint-2019-09-04.Sep 4 2019, 1:23 PM

Tobi_WMDE_SW moved this task from Sprint Backlog to Demo on the WMDE-QWERTY-Sprint-2019-09-04 board.Sep 4 2019, 1:23 PM

Fisch's instructions quoted in the task description serve to demo the fix.