Page MenuHomePhabricator

Click trash on recent changes doesn't clear open filter menus
Open, LowPublicBUG REPORT

Description

Steps to Reproduce:

Expected: the filter menu clears
Actual: while the filters menu is open the filters clear but the menu remains open

Developer notes

Likely can be solved by listening to the trash can event and hiding the other components (assuming they can access one another)

Event Timeline

kostajh added subscribers: MMiller_WMF, kostajh.

@MMiller_WMF seems like this could go into a future quarter, unless Readers-Web gets to it first.

@ovasileva -- where are you coming down on this one? Is it important to AMC? Do you plan to work on it?

@MMiller_WMF - it's not really high priority so no guarantees, but if we resolve all other AMC bugs we might have some time for it this over the next month or so.

Okay -- we'll hold off, and see if this should go into our queue later. Putting into our Q2 column so we look at it again then.

@ovasileva I don't think there's a trivial solution here. I'm happy to look into this some more, but I am a little concerned it will unnecessarily distract us from desktop improvements. I suggest removing it from the sprint board.

ovasileva lowered the priority of this task from Medium to Low.Jan 7 2020, 9:04 AM

@ovasileva I don't think there's a trivial solution here. I'm happy to look into this some more, but I am a little concerned it will unnecessarily distract us from desktop improvements. I suggest removing it from the sprint board.

sounds good to me

Unless I'm missing something here, the issue seems to me as an intended behavior.

Click filter changes input to open the filter changes menu
Click the delete icon

Actual: while the filters menu is open the filters clear but the menu remains open

By opening the filters ch menu, users indicate that they are about to change the selection of filters. Clicking on the trash bin icon would clear the filters previously selected (including in the marks for selected filters in the filter changes menu), but would not interfere with what users intend to do - to go on with filter selection. If the filter menu would close upon clicking on the trash bin, that would mean to cancel a user action and to interrupt users' intention on proceed with selecting different set of filters.

From a certain perspective this is a bug, because any click outside of the filter menu is intended to close the menu (that's part of the mechanics of how our menus work). However as @Etonkovidova pointed out (T231053#5874095), in this case the bug is somewhat convenient.

I think we're fine leaving it as is indefinitely, until we have time to fix it.