Page MenuHomePhabricator

Assert.php: Bad value for parameter $oldContent: must be a TextContent|null
Open, Needs TriagePublic

Description

Error

Request ID: XV-edQpAIC0AAFFJeEMAAABM
Request URL: www.wikidata.org//w/index.php?title=Q33232729&curid=34683193&diff=11&oldid=772301402

message
[XV-edQpAIC0AAFFJeEMAAABM] /w/index.php?title=Q33232729&curid=34683193&diff=11&oldid=772301402   Wikimedia\Assert\ParameterTypeException from line 89 of /srv/mediawiki/php-1.34.0-wmf.19/vendor/wikimedia/assert/src/Assert.php: Bad value for parameter $oldContent: must be a TextContent|null
trace
#0 /srv/mediawiki/php-1.34.0-wmf.19/includes/diff/SlotDiffRenderer.php(86): Wikimedia\Assert\Assert::parameterType(string, Wikibase\ItemContent, string)
#1 /srv/mediawiki/php-1.34.0-wmf.19/includes/diff/TextSlotDiffRenderer.php(103): SlotDiffRenderer->normalizeContents(Wikibase\ItemContent, WikitextContent, string)
#2 /srv/mediawiki/php-1.34.0-wmf.19/includes/diff/DifferenceEngine.php(1069): TextSlotDiffRenderer->getDiff(Wikibase\ItemContent, WikitextContent)
#3 /srv/mediawiki/php-1.34.0-wmf.19/includes/diff/DifferenceEngine.php(987): DifferenceEngine->getDiffBody()
#4 /srv/mediawiki/php-1.34.0-wmf.19/includes/diff/DifferenceEngine.php(949): DifferenceEngine->getDiff(string, string, string)
#5 /srv/mediawiki/php-1.34.0-wmf.19/includes/diff/DifferenceEngine.php(717): DifferenceEngine->showDiff(string, string, string)
#6 /srv/mediawiki/php-1.34.0-wmf.19/includes/page/Article.php(934): DifferenceEngine->showDiffPage(boolean)
#7 /srv/mediawiki/php-1.34.0-wmf.19/includes/page/Article.php(618): Article->showDiffPage()
#8 /srv/mediawiki/php-1.34.0-wmf.19/extensions/Wikibase/repo/includes/Actions/ViewEntityAction.php(79): Article->view()
#9 /srv/mediawiki/php-1.34.0-wmf.19/extensions/Wikibase/repo/includes/Actions/ViewEntityAction.php(54): Wikibase\ViewEntityAction->showEntityPage()
#10 /srv/mediawiki/php-1.34.0-wmf.19/includes/MediaWiki.php(507): Wikibase\ViewEntityAction->show()
#11 /srv/mediawiki/php-1.34.0-wmf.19/includes/MediaWiki.php(302): MediaWiki->performAction(Article, Title)
#12 /srv/mediawiki/php-1.34.0-wmf.19/includes/MediaWiki.php(892): MediaWiki->performRequest()
#13 /srv/mediawiki/php-1.34.0-wmf.19/includes/MediaWiki.php(523): MediaWiki->main()
#14 /srv/mediawiki/php-1.34.0-wmf.19/index.php(42): MediaWiki->run()
#15 /srv/mediawiki/w/index.php(3): include(string)
#16 {main}
Impact

11 hits in the last hour, 11 hits in the last 7 days, 36 hits in the last 30 days.

Notes

Not blocking train since it's not new. Only happens at wikidatawiki.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFri, Aug 23, 1:36 PM
zeljkofilipin updated the task description. (Show Details)
TextSlotDiffRenderer->getDiff(Wikibase\ItemContent, WikitextContent)

Yeah, diffing item and wikitext contents isn’t going to work… but apparently that’s what this URL is asking for?

index.php?title=Q33232729&curid=34683193&diff=11&oldid=772301402

Revision 11 belongs to a wikitext page, revision 772301402 to an item page. I don’t think there’s any reasonable interpretation of this URL (and I wonder where this request is coming from), we just need to handle it better.

On the other hand, other content models sometimes seem to support this – this diff, for example, is between a wikitext page and a JSON page. (It also works if you swap the compared revisions, for what it’s worth.)

mmodell changed the subtype of this task from "Task" to "Production Error".Wed, Aug 28, 11:05 PM