Page MenuHomePhabricator

Clicking to the right of table at the end of a document throws an exception (regression)
Open, Needs TriagePublic

Description

Looks like we do some calls to getNodeAndOffset for the edit cards that aren't wrapped in try/catches.

Event Timeline

Esanders created this task.Fri, Aug 23, 2:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFri, Aug 23, 2:00 PM

Change 531933 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] ve.ce.Document: Throw more errors in getNodeAndOffset and catch in surface

https://gerrit.wikimedia.org/r/531933

Note from testing: to reproduce the issue, you have to be editing in full-page mode (not section editing), otherwise the bug doesn't appear because of an invisible </section> tag following the table.

Change 531933 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] ve.ce.Surface: Don't request offsets that are out of bounds

https://gerrit.wikimedia.org/r/531933

Change 532425 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (3a669b323)

https://gerrit.wikimedia.org/r/532425

Change 532425 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (3a669b323)

https://gerrit.wikimedia.org/r/532425