Page MenuHomePhabricator
Create Task
Maniphest T231107

Improve MediaWiki logging of errors uploading files to Swift
Open, MediumPublic
Actions

Description

(tentatively assigning to Krinkle as he has better ideas about how to do this / who to route it to than I do)

When investigating Mediawiki errors of processing user uploads and re-uploading them to Swift, there's nothing in the logs to correlate between the Mediawiki event and anything one might find in the Swift logs:

https://logstash.wikimedia.org/goto/27bc8fe32d4441028fca86d41ae5f535

Simply including the filename-as-PUT'ed-to-Swift in the Mediawiki logs (e.g. wikipedia-commons-local-public.8c/8/8c/Vier_Friedenssteine_%2528K%25C3%25B6sen%2529.jpg) would be sufficient. (The filename that is presently included is a meaningless temporary local disk filename, e.g. /tmp/94aKa9.)

Details

SubjectRepoBranchLines +/-
filebackend: Convert trigger_error to PSR log warningmediawiki/coremaster+10 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

CDanis created this task.Aug 23 2019, 6:01 PM
Fano unsubscribed.Aug 24 2019, 3:15 AM
Krinkle renamed this task from improve Mediawiki logging of errors uploading files to Swift to Improve MediaWiki logging of errors uploading files to Swift.Aug 24 2019, 8:16 PM
Krinkle triaged this task as Medium priority.
Krinkle added a project: Performance-Team.
• kchapman moved this task from Inbox, needs triage to Doing (old) on the Performance-Team board.Aug 26 2019, 8:16 PM
Krinkle moved this task from Doing (old) to Blocked (old) on the Performance-Team board.Sep 26 2019, 12:59 AM
gerritbot added a comment.Sep 26 2019, 12:59 AM

Change 539216 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] filebackend: Convert trigger_error to PSR log warning

https://gerrit.wikimedia.org/r/539216

gerritbot added a project: Patch-For-Review.Sep 26 2019, 12:59 AM
gerritbot added a comment.Sep 30 2019, 7:23 PM

Change 539216 merged by jenkins-bot:
[mediawiki/core@master] filebackend: Convert trigger_error to PSR log warning

https://gerrit.wikimedia.org/r/539216

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.25; 2019-10-01).Sep 30 2019, 8:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 30 2019, 8:10 PM
Krinkle removed Krinkle as the assignee of this task.Oct 1 2019, 4:56 PM
Krinkle moved this task from Blocked (old) to Inbox, needs triage on the Performance-Team board.

Main thing is still undone - to log the actual file name that the user was interacting with (e.g. File page name on Commons).

From CR:

	$this->logger->error( "Header '{header}' is too long.", [
						'filebackend' => $this->name,
						'header' => "$na
Aaron wrote:

I suppose $op['src'] and $op['dst'] would have any relevant paths

• Gilles moved this task from Inbox, needs triage to Backlog: Maintenance, non-prioritized on the Performance-Team board.Oct 7 2019, 8:09 PM
Krinkle removed a project: MW-1.34-notes (1.34.0-wmf.25; 2019-10-01).Oct 16 2019, 10:42 PM
fgiunchedi moved this task from Inbox to Radar on the SRE-swift-storage board.Aug 25 2021, 4:19 PM
Krinkle removed a project: Performance-Team.Aug 28 2023, 2:00 PM
Krinkle unsubscribed.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits