Page MenuHomePhabricator
Create Task
Maniphest T231109

Remove Core coupling with GlobalBlocking extension
Closed, ResolvedPublic
Actions

Description

With the introduction of GetUserBlock hook in rMW7a5508573a3d: Ensure block hooks keep user state consistent with realistic blocks it is now possible to modify or add[1] more blocks to a user. Considering that in User::getGlobalBlock() when a global block is found what gets returns is a SystemBlock, instead of having the extension listen for UserIsBlockedGlobally, it could listen for GetUserBlock and add the SystemBlock with the global-block type to the user.

User::getGlobalBlock() can be deprecated and replaced with User::getBlock().

By doing this we'll be moving forward decoupling core from the GlobalBlocking extension and downsizing the User class since getGlobalBlock and all the related properties can be deprecated and eventually be removed.

I searched for all the uses of getGlobalBlock and I couldn't find any special casing that would make this transition difficult.[2]

[1] https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/master/includes/block/CompositeBlock.php
[2] https://codesearch.wmflabs.org/search/?q=getGlobalBlock&i=nope&files=&repos=

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedDreamy_JazzT231109 Remove Core coupling with GlobalBlocking extension
 ResolvedDreamy_JazzT319069 Remove global-blocks-specific methods and hook from User class
 ResolvedCyndymediawiksimT317337 Deprecate global-blocks-specific methods and hook
 ResolvedCyndymediawiksimT317325 Remove separate checks for global blocks from APIUpload and SpecialUpload
 ResolvedCyndymediawiksimT317324 GlobalBlock::appliesToRight should return true for 'upload'
 Resolved• AGueyteT317334 Remove separate checks for global blocks from PasswordReset
 Resolved• TThoabalaT317342 Investigate: Remove use of User::isBlockedGlobally and User::getGlobalBlock from Wikimedia deployed extensions
 ResolvedDreamy_JazzT318877 Remove use of User::isBlockedGlobally in CheckUser
 Resolved• AGueyteT318891 Remove usage of User::isBlockedGlobally and User::getGlobalBlock in Thanks
 ResolvedWMDE-FischT318893 Remove use of User::isBlockedGlobally and User::getGlobalBlock in FileImporter
 Resolved• AGueyteT318896 Remove use of User::isBlockedGlobally and User::getGlobalBlock in UploadWizard
 ResolvedCyndymediawiksimT318897 Remove usage of User::isBlockedGlobally in UrlShortener
 ResolvedCyndymediawiksimT318898 Remove usage of User::isBlockedGlobally and User::getGlobalBlock in VisualEditor
 ResolvedUniversal_OmegaT318900 Remove usage of User::isBlockedGlobally and User::getGlobalBlock in WikiForum
 ResolvedTchandersT257701 Add global blocks into CompositeBlocks rather than treating them separately
 ResolvedTchandersT317308 GlobalBlocking should specify block error message key
 Resolved• AGueyteT317201 Allow extensions to modify block error message key via a hook
 ResolvedSTranT317190 GlobalBlock should extend AbstractBlock instead of DatabaseBlock
 ResolvedmatmarexT363185 Remove use of User::getGlobalBlock() from WikimediaEvents
 ResolvedDreamy_JazzT387574 Hard deprecate User::getGlobalBlock

Event Timeline

dmaza created this task.Aug 23 2019, 6:17 PM
Restricted Application added subscribers: MGChecker, Aklapper. · View Herald TranscriptAug 23 2019, 6:17 PM
dmaza added projects: Platform Engineering, MediaWiki-User-management.Aug 23 2019, 7:17 PM
• WDoranWMF moved this task from Inbox to Feature Requests to Review on the Platform Engineering board.Aug 23 2019, 7:29 PM
JJMC89 moved this task from Backlog to User blocking on the MediaWiki-User-management board.Aug 23 2019, 8:11 PM
Aklapper added a project: Core Platform Team Initiatives (Decoupling (CDP2)).Aug 24 2019, 12:08 PM
dmaza added a project: GlobalBlocking.Aug 26 2019, 6:04 PM
Niharika moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment-Team board.Aug 30 2019, 8:30 PM
• WDoranWMF removed projects: Core Platform Team Initiatives (Decoupling (CDP2)), Platform Engineering.Sep 11 2019, 2:42 PM
• WDoranWMF subscribed.

Since anti-harassment is taking this, we're untagging CPT, please retag if there is work/input needed from us.

• aezell subscribed.EditedSep 11 2019, 2:59 PM

@WDoranWMF It's not actually sure that we will take on this work. We wrote this task so that "someone" in the future could do this work. The decoupling initiative seemed a good candidate. We wrote it because we are knee deep in the code at the moment.

Given recent product discussions, it's highly unlikely we'll have time to tackle this. Our approach here was to provide some insight from the trenches for those people and teams engaged in higher level architectural refactoring.

This got moved to our Estimation column a bit too eagerly perhaps.

Niharika removed a project: Anti-Harassment-Team.Sep 19 2019, 6:46 PM
Niharika subscribed.Sep 19 2019, 6:50 PM

@WDoranWMF Anti-Harassment will not be taking on this ticket. Feel free to prioritise per CPT plans.

DannyS712 edited projects, added MediaWiki-Blocks; removed MediaWiki-User-management.Apr 25 2020, 12:09 AM
Restricted Application added a project: MediaWiki-User-management. · View Herald TranscriptApr 25 2020, 12:10 AM
Aklapper removed a project: MediaWiki-User-management.Apr 25 2020, 12:23 PM
taavi awarded a token.Jan 22 2022, 12:09 PM
Tchanders added a subtask: T319069: Remove global-blocks-specific methods and hook from User class.Sep 30 2022, 7:35 PM
Tchanders added a project: Anti-Harassment-Team.Mar 21 2023, 5:53 PM
Tchanders subscribed.

Adding Anti-Harassment-Team back, since we did end up taking this work, and should do T319069: Remove global-blocks-specific methods and hook from User class when the stable interface policy allows.

• TAdeleye_WMF edited projects, added Trust and Safety Product Team (PM); removed Anti-Harassment-Team.May 14 2024, 4:29 PM
• TAdeleye_WMF moved this task from PM to Needs Triage on the Trust and Safety Product Team board.May 14 2024, 4:30 PM
• TAdeleye_WMF edited projects, added Trust and Safety Product Team; removed Trust and Safety Product Team (PM).
Dreamy_Jazz moved this task from Needs Triage to Engineering on the Trust and Safety Product Team board.Feb 28 2025, 5:41 PM
Dreamy_Jazz edited projects, added Trust and Safety Product Team (Engineering); removed Trust and Safety Product Team.
Restricted Application edited projects, added Trust and Safety Product Team; removed Trust and Safety Product Team (Engineering). · View Herald TranscriptFeb 28 2025, 5:41 PM
Dreamy_Jazz moved this task from Inbox to Engineering on the Trust and Safety Product Team board.Feb 28 2025, 5:49 PM
Dreamy_Jazz edited projects, added Trust and Safety Product Team (Engineering); removed Trust and Safety Product Team.
kostajh moved this task from Engineering to Engineering on the Trust and Safety Product Team board.Mar 10 2025, 12:44 PM
kostajh edited projects, added Trust and Safety Product Team; removed Trust and Safety Product Team (Engineering).
Dreamy_Jazz closed this task as Resolved.Oct 3 2025, 3:36 PM
Dreamy_Jazz claimed this task.
Dreamy_Jazz closed subtask T319069: Remove global-blocks-specific methods and hook from User class as Resolved.
Dreamy_Jazz subscribed.

T401594: Remove the UserIsBlockedGlobally hook dropped the methods from the User class. T401594: Remove the UserIsBlockedGlobally hook will handle removing the associated hook, but given that hook is no longer run I think we can call the overall goal of this task done

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits