Use CommentStore::COMMENT_CHARACTER_LIMIT for maximum length in Global Block reasons
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	DannyS712
	Aug 24 2019, 8:57 PM

Description

Currently, the maximum length for a reason for a global block is limited to 255 characters, the old limit on the length of comments. This has been raised to 500, and to ensure that any further changes are automatically used, CommentStore::COMMENT_CHARACTER_LIMIT should be used for the limit.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Increase global block reason maximum length to use `CommentStore::COMMENT_CHARACTER_LIMIT`	mediawiki/extensions/GlobalBlocking	master	+1 -1

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	None	T13543 Use CommentStore::COMMENT_CHARACTER_LIMIT everywhere
Resolved	DannyS712	T231146 Use CommentStore::COMMENT_CHARACTER_LIMIT for maximum length in Global Block reasons
Resolved	Marostegui	T231172 Alter gbw_reason/gb_reason/gbw_by_text on WMF production
Resolved	DannyS712	T231170 Alter globalblocking tables to allow longer comments
Resolved	DannyS712	T231174 Change varchar columns into varbinary

Event Timeline

DannyS712 created this task.Aug 24 2019, 8:57 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 24 2019, 8:57 PM

Change 532099 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/GlobalBlocking@master] Increase global block reason maximum length to use CommentStore::COMMENT_CHARACTER_LIMIT

https://gerrit.wikimedia.org/r/532099

gerritbot added a project: Patch-For-Review.Aug 24 2019, 8:57 PM

DannyS712 moved this task from Unsorted to Awaiting review and deployment on the User-DannyS712 board.Aug 24 2019, 8:58 PM

Reedy closed subtask T231170: Alter globalblocking tables to allow longer comments as Resolved.Aug 25 2019, 8:32 PM

Marostegui closed subtask T231172: Alter gbw_reason/gb_reason/gbw_by_text on WMF production as Resolved.Sep 26 2019, 6:16 AM

Change 532099 merged by jenkins-bot:
[mediawiki/extensions/GlobalBlocking@master] Increase global block reason maximum length to use CommentStore::COMMENT_CHARACTER_LIMIT

https://gerrit.wikimedia.org/r/532099

Maintenance_bot removed a project: Patch-For-Review.Oct 15 2019, 1:10 PM

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.2; 2019-10-15).Oct 15 2019, 2:00 PM

DannyS712 closed this task as Resolved.Oct 30 2019, 7:44 AM

DannyS712 moved this task from Awaiting review and deployment to Merged on the User-DannyS712 board.Nov 26 2019, 11:55 AM