Page MenuHomePhabricator
Create Task
Maniphest T231181

Add PLURAL validators for projects using the new Validator framework
Closed, ResolvedPublic
Actions

Description

We need to add plural validators for various projects based on,

  • Ruby
  • Gettext
  • SmartFormat

Plural validator should:

  • Not allow plural if the source does not have it
  • Require plural unless the language has only 1 plural form (unless enforced by the file format / software using it)
  • Check that required forms are provided for each plural instance

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/Translatemaster+311 -1Add SmartFormat plural validator
mediawiki/extensions/Translatemaster+1 K -6Add UnicodePluralValidator
mediawiki/extensions/Translatemaster+466 -80Add GettextPluralValidator
Customize query in gerrit

Related Objects
Search...

Event Timeline

abi_ created this task.Aug 26 2019, 4:45 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 26 2019, 4:45 AM
abi_ added a parent task: T224025: Migrate existing projects to use the new Validator framework.Aug 26 2019, 4:45 AM
abi_ added a project: Language-Team (Language-2019-July-September).Aug 28 2019, 8:31 AM
abi_ added a subscriber: Pginer-WMF.

@Pginer-WMF - Adding this to the current language team board as this is basically a sub task.

abi_ moved this task from Backlog to Priority backlog on the Language-Team (Language-2019-July-September) board.Aug 28 2019, 8:31 AM
Pginer-WMF added a comment.Aug 28 2019, 8:46 AM
In T231181#5444857, @abi_ wrote:

@Pginer-WMF - Adding this to the current language team board as this is basically a sub task.

Sounds good. Thanks for pinging!

gerritbot added a comment.Sep 9 2019, 3:06 PM

Change 535208 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/Translate@master] Add GettextPluralValidator

https://gerrit.wikimedia.org/r/535208

gerritbot added a project: Patch-For-Review.Sep 9 2019, 3:06 PM
Nikerabbit added a comment.Sep 9 2019, 3:48 PM

Do you have an example of a project that uses plurals in Python?

abi_ reassigned this task from abi_ to Nikerabbit.Sep 10 2019, 8:43 AM
abi_ moved this task from Priority backlog to In Progress on the Language-Team (Language-2019-July-September) board.
In T231181#5475503, @Nikerabbit wrote:

Do you have an example of a project that uses plurals in Python?

No, not at this point. I'll check and get back to you.

gerritbot added a comment.Sep 12 2019, 7:55 AM

Change 535208 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Add GettextPluralValidator

https://gerrit.wikimedia.org/r/535208

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.23; 2019-09-17).Sep 12 2019, 8:00 AM
Maintenance_bot removed a project: Patch-For-Review.Sep 12 2019, 8:10 AM
gerritbot added a comment.Sep 17 2019, 6:58 PM

Change 537491 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/Translate@master] Add UnicodePluralValidator

https://gerrit.wikimedia.org/r/537491

gerritbot added a project: Patch-For-Review.Sep 17 2019, 6:58 PM
Nikerabbit moved this task from In Progress to In Review on the Language-Team (Language-2019-July-September) board.Sep 18 2019, 6:43 AM
gerritbot added a comment.Sep 25 2019, 4:20 AM

Change 537491 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Add UnicodePluralValidator

https://gerrit.wikimedia.org/r/537491

Maintenance_bot removed a project: Patch-For-Review.Sep 25 2019, 5:10 AM
Pginer-WMF edited projects, added Language-Team (Language-2019-October-December); removed Language-Team (Language-2019-July-September).Oct 9 2019, 11:51 AM
Pginer-WMF moved this task from Backlog to In Review on the Language-Team (Language-2019-October-December) board.
Nikerabbit moved this task from In Review to Needs QA on the Language-Team (Language-2019-October-December) board.Oct 24 2019, 6:30 AM

I had written a script that scrapes plural forms from rails-i18n repository. The results are in P9464.

Maybe someone wants to compare these against the CLDR plurals to see if there are differences. If not, I think the UnicodePlural class is sufficient.

Nikerabbit updated the task description. (Show Details)Oct 30 2019, 7:05 AM
Nikerabbit moved this task from Needs QA to In Progress on the Language-Team (Language-2019-October-December) board.

I'm currently working on the SmartFormat validator used by DiscordWikiBot.

Nikerabbit added a parent task: T236516: Add DiscordWikiBot to Translatewiki.net.Oct 30 2019, 7:12 AM
Nikerabbit triaged this task as Medium priority.Oct 30 2019, 8:27 AM
Nikerabbit moved this task from Backlog to translation aids on the MediaWiki-extensions-Translate board.
Nikerabbit removed a project: translatewiki.net.
gerritbot added a comment.Oct 30 2019, 9:37 AM

Change 547154 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/Translate@master] Add SmartFormat plural validator

https://gerrit.wikimedia.org/r/547154

gerritbot added a project: Patch-For-Review.Oct 30 2019, 9:37 AM
Nikerabbit moved this task from In Progress to In Review on the Language-Team (Language-2019-October-December) board.Oct 30 2019, 9:37 AM
gerritbot added a comment.Nov 4 2019, 9:28 AM

Change 547154 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Add SmartFormat plural validator

https://gerrit.wikimedia.org/r/547154

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.5; 2019-11-05).Nov 4 2019, 10:00 AM
Maintenance_bot removed a project: Patch-For-Review.Nov 4 2019, 10:11 AM
Nikerabbit removed projects: MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), MW-1.34-notes (1.34.0-wmf.23; 2019-09-17).Nov 4 2019, 1:13 PM
Nikerabbit updated the task description. (Show Details)
Nikerabbit moved this task from In Review to Recheck after deployment on the Language-Team (Language-2019-October-December) board.
Pginer-WMF edited projects, added Language-Team (Language-2020-January-March); removed Language-Team (Language-2019-October-December).Jan 2 2020, 8:14 AM
Pginer-WMF moved this task from Backlog to Recheck after deployment on the Language-Team (Language-2020-January-March) board.
abi_ added a comment.Jan 7 2020, 9:22 AM

We currently have a patch to add UnicodePlural validator for OpenStreetMaps (https://gerrit.wikimedia.org/r/c/translatewiki/+/562045) which is a Ruby project. Once we have deployed that, and tested it on translatewiki.net, I think this patch can be resolved.

abi_ closed this task as Resolved.Jan 13 2020, 2:43 AM
abi_ moved this task from Recheck after deployment to Done on the Language-Team (Language-2020-January-March) board.
In T231181#5780904, @abi_ wrote:

We currently have a patch to add UnicodePlural validator for OpenStreetMaps (https://gerrit.wikimedia.org/r/c/translatewiki/+/562045) which is a Ruby project. Once we have deployed that, and tested it on translatewiki.net, I think this patch can be resolved.

The related patch has been deployed, and tested. No issues noticed.

image.png (622×1 px, 139 KB)

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL