Use documentation builds as part of CI testing
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Halfak
	Aug 26 2019, 4:12 PM

Related Objects
Search...

Status	Assigned	Task
Resolved	• ACraze	T230517 Automate docs build for model repos
Resolved	• ACraze	T231212 Use documentation builds as part of CI testing
Open	None	T233270 Fix sklearn sphinx errors

Event Timeline

Halfak created this task.Aug 26 2019, 4:12 PM

Restricted Application added a project: artificial-intelligence. · View Herald TranscriptAug 26 2019, 4:12 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

• ACraze added a parent task: T230517: Automate docs build for model repos.Sep 3 2019, 10:24 PM

I've got PRs up for each of the repos now:

https://github.com/wikimedia/editquality/pull/214
https://github.com/wikimedia/articlequality/pull/94
https://github.com/wikimedia/drafttopic/pull/39
https://github.com/wikimedia/draftquality/pull/33
https://github.com/wikimedia/revscoring/pull/451

I wonder if we should be using -nW

    -n                nit-picky mode, warn about all missing references
[...]
    -W                turn warnings into errors

This would make it so that any missing ref would cause an error. We'd need to do some work to make docs build correctly in order to get this to pass, but it seems like it would be an asset for later.

I just updated the wikimedia/revscoring PR with -anW and did the work to get it passing.

Halfak moved this task from Review to Parked on the Machine-Learning-Team (Active Tasks) board.Sep 9 2019, 4:49 PM

OK all the repos should be good to go now. @ACraze please review my work and feel free to merge.

Halfak moved this task from Parked to Review on the Machine-Learning-Team (Active Tasks) board.Sep 16 2019, 4:46 PM

Alrighty @Halfak I have the article quality and revscoring PRs passing now:

https://github.com/wikimedia/articlequality/pull/94

https://github.com/wikimedia/revscoring/pull/451

Also I have added a new task for the intersphinx sklearn issue: T233270

• ACraze added a subtask: T233270: Fix sklearn sphinx errors.Sep 19 2019, 12:08 AM