Maniphest T231282

cancel modal
Closed, ResolvedPublic5 Estimated Story Points
Actions

Assigned To

Lydia_Pintscher

Authored By

	• Pablo-WMDE
	Aug 27 2019, 9:29 AM

Tags

Referenced Files

	F30209979: has 1.3.png
	Sep 3 2019, 11:31 AM

Subscribers

Lydia_Pintscher

Description

Problem:
We currently don't let the user get out of the modal without reloading the page. We should let them do this in a better way.

Screenshots/mockups:
Cancel button in the top left corner ButtonWidget (frameless, icon only)

has 1.3.png (488×500 px, 22 KB)

BDD
GIVEN a Wikidata Bridge modal
WHEN I click cancel
THEN the modal is closed
AND my changes are lost

Acceptance criteria:

pressing cancel closes the modal
pressing esc closes the modal
clicking outside the modal does nothing
there will be no warning when closing the modal
all unsaved changes will be lost

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Lydia_Pintscher	T231282 cancel modal
		Resolved		• Pablo-WMDE	T233791 Add cancel button
		Resolved		• Matthias_Geisler_WMDE	T233793 React to escape
		Resolved		Lucas_Werkmeister_WMDE	T233794 React to app's cancel event
		Resolved		Lucas_Werkmeister_WMDE	T233795 Add cancel button to app and emit close event
		Resolved		Michael	T233796 browser test canceling

Event Timeline

• Pablo-WMDE created this task.Aug 27 2019, 9:29 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 27 2019, 9:29 AM

• Pablo-WMDE renamed this task from Add cancel button to Add cancel/close button.Aug 29 2019, 9:05 AM

• Pablo-WMDE added a subscriber: Charlie_WMDE.

Lydia_Pintscher added a project: Wikidata.Sep 2 2019, 7:55 PM

@Charlie_WMDE mockup prettyplz

Charlie_WMDE updated the task description. (Show Details)Sep 3 2019, 11:31 AM

darthmon_wmde renamed this task from get out of modal to cancel modal.Sep 10 2019, 8:50 AM

darthmon_wmde set the point value for this task to 5.Sep 10 2019, 8:55 AM

Lydia_Pintscher moved this task from Ready to estimate to Ready to pick up on the Wikidata-Bridge board.Sep 20 2019, 10:43 AM

Lydia_Pintscher triaged this task as High priority.Sep 20 2019, 10:50 AM

darthmon_wmde edited projects, added Wikidata-Bridge-Sprint-6; removed Wikidata-Bridge.Sep 24 2019, 2:43 PM

Lucas_Werkmeister_WMDE closed subtask T233794: React to app's cancel event as Resolved.Sep 30 2019, 3:22 PM

• Matthias_Geisler_WMDE moved this task from To do to Doing on the Wikidata-Bridge-Sprint-6 board.Oct 1 2019, 3:49 PM

Lucas_Werkmeister_WMDE closed subtask T233795: Add cancel button to app and emit close event as Resolved.Oct 2 2019, 10:43 AM

Lucas_Werkmeister_WMDE closed subtask T233791: Add cancel button as Resolved.

Lucas_Werkmeister_WMDE moved this task from Doing to Verification on the Wikidata-Bridge-Sprint-6 board.

\o/

Lydia_Pintscher closed subtask T233793: React to escape as Resolved.Oct 7 2019, 8:56 AM

Michael closed subtask T233796: browser test canceling as Resolved.Oct 7 2019, 9:07 AM