Page MenuHomePhabricator

Stop running HHVM tests for TwnMainPage
Closed, ResolvedPublic

Description

Split from T231270: Failing build process: Variadic params with type constraints are not supported in non-Hack files.

Since TwnMainPage is only used by translatewiki.net, which uses PHP, there is no added value running HHVM tests. In fact, it decreases value, as the parent task indicates, by limiting what we can do.

Event Timeline

Nikerabbit triaged this task as Normal priority.
Nikerabbit updated the task description. (Show Details)Tue, Aug 27, 12:20 PM

It seems extension-quibble should be replaced with either extension-quibble-composer-nohhvm or extension-quibble-php72-plus. I am not fully sure what are the differences. Former seems better, but what exactly does the composer part in it mean?

hashar added a subscriber: hashar.EditedTue, Aug 27, 6:36 PM

For historical reasons CI default to use mediawiki/vendor.git to ship the composer dependencies.

extension-quibble-php72-plus uses mediawiki/vendor.git and does not use php7.0 / php7.1
extension-quibble-composer-nohhvm uses composer install instead.

Or we craft yet another template that uses composer install and only uses php 7.2. I guess that depends on which version of php you are using on translatewiki.net.

We're still on PHP 7.1. TwnMainPage doesn't have much dependencies, so extension-quibble-composer-nohhvm seems good and appropriate to me.

Change 532779 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[integration/config@master] TwnMainPage: switch to extension-quibble-composer-nohhvm

https://gerrit.wikimedia.org/r/532779

Change 532779 merged by jenkins-bot:
[integration/config@master] TwnMainPage: switch to extension-quibble-composer-nohhvm

https://gerrit.wikimedia.org/r/532779

Mentioned in SAL (#wikimedia-releng) [2019-08-27T20:25:35Z] <James_F> Zuul: TwnMainPage: switch to extension-quibble-composer-nohhvm T231289

hashar closed this task as Resolved.Tue, Sep 3, 11:48 AM