Admins on mobile devices no have option to delete, protect or move pages. There is no link to non-admin features such as "page move".
With the completion of T274980 all of these pages are now mobile-friendly and should be made available in the UI as part of the overflow menu, to those that can use it as part of the "Advanced Mobile Contributions" mode.
Developer notes
Note: Delete is possible via accessing the URI https://en.m.wikipedia.beta.wmflabs.org/wiki/Spain?action=delete - we just don't link to it.
Moving page on mobile is possible by accessing Special:MovePage/PageName and it is mobile friendly.
Acceptance criteria
- New icons have been added to the existing skins.minerva.overflow.icons module: trash, lock, unLock and move
- The DefaultOverflowBuilder and UserNamespaceOverflowBuilder are adapted to add the new actions based on the user and permission manager. For now duplicate the logic in SkinTemplate::buildContentNavigationUrls where necessary into useful helper methods.
e.g. for protection:
if ( $permissionManager->quickUserCan( 'protect', $user, $title ) && $title->getRestrictionTypes() && $permissionManager->getNamespaceRestrictionLevels( $title->getNamespace(), $user ) !== [ '' ] ) { $mode = $title->isProtected() ? 'unprotect' : 'protect'; $content_navigation['actions'][$mode] = [ 'class' => ( $onPage && $action == $mode ) ? 'selected' : false, 'text' => wfMessageFallback( "$skname-action-$mode", $mode ) ->setContext( $this->getContext() )->text(), 'href' => $title->getLocalURL( "action=$mode" ) ]; }
QA steps
For purpose of QA, more menu refers to this element:
1. As anonymous user visiting mobile site.
- I see no more menu on https://en.m.wikipedia.beta.wmflabs.org/wiki/Selenium_Echo_link_test_0.7791232640420875
- I see a more menu on https://en.m.wikipedia.beta.wmflabs.org/wiki/User:Jdlrobson but no protect link
2. As logged in user on mobile site with AMC disabled.
- I see no more menu on https://en.m.wikipedia.beta.wmflabs.org/wiki/Selenium_Echo_link_test_0.7791232640420875
- I see a more menu on https://en.m.wikipedia.beta.wmflabs.org/wiki/User:Jdlrobson but no protect links.
3. As logged in user on mobile site with AMC enabled WITHOUT permissions.
- Confirm that https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:MovePage/User:Jdlrobson shows a permision error.
- I see a more menu on https://en.m.wikipedia.beta.wmflabs.org/wiki/Selenium_Echo_link_test_0.7791232640420875 but there are no links to protect, move or delete in the menu.
- I see more menu on https://en.m.wikipedia.beta.wmflabs.org/wiki/User:Jdlrobson but there are no links to protect, move or delete in the menu.
4. As logged in user on mobile site with AMC enabled WITH permissions.
- Confirm that https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:MovePage/User:Jdlrobson does not show a permision error. Make sure AMC is enabled. If it shows a permission error, ask Jdlrobson to grant you permissions to run this set of tests.
- I see a more menu on https://en.m.wikipedia.beta.wmflabs.org/wiki/Selenium_Echo_link_test_0.7791232640420875 and there are links to protect, move or delete in the menu. Each of those links should take you to a functional page.
- I see a more menu on https://en.m.wikipedia.beta.wmflabs.org/wiki/User:Jdlrobson and there are links to protect, move or delete in the menu. Each of those links should take you to a functional page.
QA Results - Beta
AC | Status | Details |
---|---|---|
1 | ✅ | T231291#7046396 |
2 | ✅ | T231291#7046396 |
3 | ✅ | T231291#7046396 |
4 | ⬜ | T231291#7046396 |
QA Results -Prod
AC | Status | Details |
---|---|---|
1 | ✅ | T231291#7096978 |
2 | ✅ | T231291#7096978 |
3 | ✅ | T231291#7096978 |
4 | ⬜ | T231291#7096978 |