Page MenuHomePhabricator

[Regression wmf.20] Uncaught TypeError: Cannot read property 'getRoot' of undefined appears when adding new citation/chemical and math formula
Closed, ResolvedPublic

Description

Steps to replicate:

  1. Open VE for any page
  2. Add a citation from Cite>Manual>Website/Book etc or add a chemical/math formula from Insert menu.

Observe that there is an error in the console Uncaught TypeError: Cannot read property 'getRoot' of undefined.

Event Timeline

Ryasmeen created this task.Aug 27 2019, 8:09 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 27 2019, 8:09 PM

Change 532802 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Follow-up I196f5bd88: Fix typo (set node=this)

https://gerrit.wikimedia.org/r/532802

Esanders triaged this task as High priority.Aug 27 2019, 9:36 PM

Follow up to the fix for T231094.

Change 532802 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Follow-up I196f5bd88: Fix typo (set node=this)

https://gerrit.wikimedia.org/r/532802

Change 532804 had a related patch set uploaded (by Jforrester; owner: Esanders):
[VisualEditor/VisualEditor@wmf/1.34.0-wmf.20] Follow-up I196f5bd88: Fix typo (set node=this)

https://gerrit.wikimedia.org/r/532804

Change 532806 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (c4c37f4e0)

https://gerrit.wikimedia.org/r/532806

Change 532804 merged by Jforrester:
[VisualEditor/VisualEditor@wmf/1.34.0-wmf.20] Follow-up I196f5bd88: Fix typo (set node=this)

https://gerrit.wikimedia.org/r/532804

Change 532808 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@wmf/1.34.0-wmf.20] Update VE core submodule to 1.34.0-wmf.20 HEAD (5ee439401)

https://gerrit.wikimedia.org/r/532808

Change 532808 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@wmf/1.34.0-wmf.20] Update VE core submodule to 1.34.0-wmf.20 HEAD (5ee439401)

https://gerrit.wikimedia.org/r/532808

Mentioned in SAL (#wikimedia-operations) [2019-08-27T22:29:56Z] <jforrester@deploy1001> Synchronized php-1.34.0-wmf.20/extensions/VisualEditor/lib/ve/src/ce/nodes/ve.ce.GeneratedContentNode.js: T231381 Follow-up I196f5bd88: Fix typo (set node=this) (duration: 00m 57s)

Jdforrester-WMF raised the priority of this task from High to Unbreak Now!.
Jdforrester-WMF added a subscriber: Jdforrester-WMF.

Backported to production and manually verified with Rummana.

Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptAug 27 2019, 10:30 PM
Jdforrester-WMF closed this task as Resolved.Aug 27 2019, 10:30 PM
Jdforrester-WMF removed a project: Patch-For-Review.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptAug 27 2019, 10:30 PM

Change 532806 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (c4c37f4e0)

https://gerrit.wikimedia.org/r/532806