Page MenuHomePhabricator
Create Task
Maniphest T231386

dispatchUser() in SpecialRedirect.php should use a 302 http status code instead of a 301 to avoid certain caching issues
Closed, ResolvedPublic
Actions

Description

Per the public conversation on the related patch: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/530433/2/includes/specials/SpecialRedirect.php#93

dispatchUser() in SpecialRedirect.php should use a 302 http status code instead of a 301 to avoid certain caching issues. This is a public task as 1) this issue was already publicly-discussed on gerrit 2) this is conceivably more code-hardening than a bona fide security issue.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
dispatchUser() should use a 302 http status codeReedymediawiki/coreREL1_31+3 -1
dispatchUser() should use a 302 http status codeReedymediawiki/coreREL1_32+3 -1
dispatchUser() should use a 302 http status codeSBassettmediawiki/coremaster+3 -1
dispatchUser() should use a 302 http status codeReedymediawiki/coreREL1_33+3 -1
Customize query in gerrit

Event Timeline

sbassett created this task.Aug 27 2019, 8:52 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 27 2019, 8:52 PM
sbassett triaged this task as Low priority.Aug 27 2019, 8:53 PM
sbassett moved this task from Backlog to In Progress on the user-sbassett board.
gerritbot added a comment.Aug 27 2019, 8:57 PM

Change 532795 had a related patch set uploaded (by SBassett; owner: SBassett):
[mediawiki/core@master] dispatchUser() in should use a 302 http status code

https://gerrit.wikimedia.org/r/532795

gerritbot added a project: Patch-For-Review.Aug 27 2019, 8:57 PM
Aklapper edited projects, added: MediaWiki-Special-pages; removed: MediaWiki-General.Sep 1 2019, 12:48 PM
gerritbot added a comment.Sep 10 2019, 6:15 PM

Change 535659 had a related patch set uploaded (by Reedy; owner: SBassett):
[mediawiki/core@REL1_33] dispatchUser() should use a 302 http status code

https://gerrit.wikimedia.org/r/535659

gerritbot added a comment.Sep 10 2019, 6:15 PM

Change 535660 had a related patch set uploaded (by Reedy; owner: SBassett):
[mediawiki/core@REL1_32] dispatchUser() should use a 302 http status code

https://gerrit.wikimedia.org/r/535660

gerritbot added a comment.Sep 10 2019, 6:39 PM

Change 535659 merged by jenkins-bot:
[mediawiki/core@REL1_33] dispatchUser() should use a 302 http status code

https://gerrit.wikimedia.org/r/535659

gerritbot added a comment.Sep 10 2019, 6:53 PM

Change 532795 merged by jenkins-bot:
[mediawiki/core@master] dispatchUser() should use a 302 http status code

https://gerrit.wikimedia.org/r/532795

Reedy removed a project: Patch-For-Review.Sep 10 2019, 6:54 PM

Just REL1_31 to be dealt with. Will need supporting backports to work though

ReleaseTaggerBot added projects: MW-1.33-notes, MW-1.34-notes (1.34.0-wmf.23; 2019-09-17).Sep 10 2019, 7:00 PM
sbassett added a comment.Sep 10 2019, 7:22 PM

@Reedy Er, REL1_32 still appears un-merged as it needs the 301-checking in dispatch()?

Reedy added a comment.Sep 10 2019, 7:23 PM
In T231386#5480621, @sbassett wrote:

@Reedy Er, REL1_32 still appears un-merged as it needs the 301-checking in dispatch()?

Distractions!

Yeah, REL1_32 needs a supporting backport too

sbassett added a comment.Sep 10 2019, 7:24 PM

@Reedy - lol, wasn't commanding, just noting :)

Reedy added a comment.Sep 10 2019, 7:25 PM

I was meaning I was distracted ;)

gerritbot added a comment.Sep 21 2019, 9:07 PM

Change 538392 had a related patch set uploaded (by Reedy; owner: SBassett):
[mediawiki/core@REL1_31] dispatchUser() should use a 302 http status code

https://gerrit.wikimedia.org/r/538392

gerritbot added a project: Patch-For-Review.Sep 21 2019, 9:07 PM

Change 535660 merged by jenkins-bot:
[mediawiki/core@REL1_32] dispatchUser() should use a 302 http status code

https://gerrit.wikimedia.org/r/535660

gerritbot added a comment.Sep 21 2019, 9:13 PM

Change 538392 merged by jenkins-bot:
[mediawiki/core@REL1_31] dispatchUser() should use a 302 http status code

https://gerrit.wikimedia.org/r/538392

ReleaseTaggerBot added projects: MW-1.32-notes, MW-1.31-release-notes.Sep 21 2019, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 21 2019, 10:10 PM
sbassett closed this task as Resolved.Sep 23 2019, 9:34 PM
sbassett moved this task from In Progress to Done on the user-sbassett board.

@Reedy got the backports merged (thanks!) so this should be done for now.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits