Page MenuHomePhabricator

GeoHack coordinates are misaligned again
Open, Needs TriagePublic

Description

GeoHack coordinates are misaligned again for me (possibly because of the recent change to where the language links are displayed). It looks like this is because the position is now set based on the top of the prose, so the coordinates usually end up floating above the infobox area. I also have the XTools gadget turned on, which adds additional vertical space between the h1 line and the start of the prose.

Event Timeline

All right, seems to be related to the position:relative on #mw-content-text. That maybe shouldn't even be there (should probably be on a block around/under the firstheading)...

Two questions (for you guys, or just in general):

  1. What exactly is geohack, that's adding these coordinates in the first place? Is this an extension, template, what?
  2. Why was the position:relative put there, does it actually need to be there, or can we move it?
RogueScholar added a comment.EditedThu, Sep 12, 6:53 AM

What exactly is geohack, that's adding these coordinates in the first place? Is this an extension, template, what?

I believe it's an extension. You can manually generate the full output for any set of geo-coordinates from this page. On English Wikipedia it's use is overwhelmingly the result of the {{Coord}} template, and this link that's being placed improperly is a clickable JavaScript popup with a compact version consisting of various links to elements of the full output, generated when the template includes the value title for the |display= parameter.

Why was the position:relative put there, does it actually need to be there, or can we move it?

I have zero knowledge as to when or why position:relative became attached to it and am not aware of any constraint to moving it.

All right, ashley found the things:

Which basically means that Timeless probably isn't going to change this again, and we just need to change the offset for Timeless specifically in the template skinstyles to reflect this, or stuff. Anyone know where that is?

Nevermind, looks like it's in mediawiki:Timeless.css... I'll just update that, I guess?!

Change 536322 had a related patch set uploaded (by Isarra; owner: Isarra):
[mediawiki/skins/Timeless@master] Include contentSub in relative-positioned body-contents

https://gerrit.wikimedia.org/r/536322

Note that this will also require the VE-specific styles to be removed entirely once merged/deployed, as they will no longer be needed at that point.

Slight problem in that different browsers appear to have wildly different line-heights and I do not know how to account for that with css when the problem is that we are trying to insert content data into a non-content part of the page...

So the new offset really only works in chrome on windows; elsewhere it's too low and bonks into the cactions tabs. On the other hand, firefox on windows and linux and even chrome on linux all seem to be a little more consistent with each other, but doing it for them causes it to overlap the firstheading on the other...

Okaaaay, the new version of the patch should do it, but will require another update to the above localpage once it goes live...

Change 536322 merged by jenkins-bot:
[mediawiki/skins/Timeless@master] Create wrapper for all junk below firstHeading, including nav stuff

https://gerrit.wikimedia.org/r/536322