Page MenuHomePhabricator
Create Task
Maniphest T231404

Client-side event impression event logging is broken
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

This is due to an outdated check of mw.config.get( 'wgEventLoggingBaseUri' ) to see if the EventLogging extension is enabled. Along the way, we should complete the update of the use of EventLogging in the CN display module, as per T214709. (Here's the change removing access to that config.)

Details

SubjectRepoBranchLines +/-
Use EventLogging API directly for impression eventmediawiki/extensions/CentralNoticemaster+7 -31
Customize query in gerrit

Related Objects
Search...

Event Timeline

AndyRussG created this task.Aug 28 2019, 6:08 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 28 2019, 6:08 AM
AndyRussG removed a project: Epic.Aug 28 2019, 3:30 PM
AndyRussG claimed this task.Aug 30 2019, 3:11 PM
AndyRussG added a project: Fundraising Sprint Quick and the Deadlocked.
AndyRussG set the point value for this task to 2.
AndyRussG moved this task from Backlog to Doing on the Fundraising Sprint Quick and the Deadlocked board.
• DStrine moved this task from Triage to Current Sprint on the Fundraising-Backlog board.Sep 3 2019, 4:11 PM
gerritbot added a comment.Sep 3 2019, 7:25 PM

Change 534222 had a related patch set uploaded (by AndyRussG; owner: AndyRussG):
[mediawiki/extensions/CentralNotice@master] Use EventLogging API directly for impression event

https://gerrit.wikimedia.org/r/534222

gerritbot added a project: Patch-For-Review.Sep 3 2019, 7:25 PM
AndyRussG moved this task from Doing to Review on the Fundraising Sprint Quick and the Deadlocked board.Sep 3 2019, 7:30 PM
• DStrine added a project: Fundraising Sprint Rocky Horror Presentation Layer.Sep 3 2019, 8:23 PM
Ejegg moved this task from Backlog to Review on the Fundraising Sprint Rocky Horror Presentation Layer board.Sep 3 2019, 11:08 PM
gerritbot added a comment.Sep 5 2019, 12:36 PM

Change 534222 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@master] Use EventLogging API directly for impression event

https://gerrit.wikimedia.org/r/534222

Maintenance_bot removed a project: Patch-For-Review.Sep 5 2019, 1:10 PM
AndyRussG moved this task from Review to Pending Deployment on the Fundraising Sprint Rocky Horror Presentation Layer board.Sep 5 2019, 3:27 PM
AndyRussG moved this task from Pending Deployment to Deployed on the Fundraising Sprint Rocky Horror Presentation Layer board.Sep 13 2019, 2:50 PM
AndyRussG added a comment.Sep 13 2019, 3:33 PM

This is included in 1.34.0-wmf.22, but because of a train delay, it hasn't been deployed to the group 2 (which includes Wikipedia). However, I've verified that it's working on other production wikis.

• DStrine added a project: Fundraising Sprint Sysadmin Kane.Sep 17 2019, 8:13 PM
AndyRussG moved this task from Backlog to Doing on the Fundraising Sprint Sysadmin Kane board.Sep 17 2019, 8:46 PM
AndyRussG moved this task from Doing to Deployed on the Fundraising Sprint Sysadmin Kane board.
Ejegg closed this task as Resolved.Oct 1 2019, 8:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL