Page MenuHomePhabricator

Fixes for running WebPageTest
Closed, ResolvedPublic

Description

There's a couple issues with running WebPageTest that we need to fix before we can make the switch. Lets keep this issue open until all of them are fixed.

At the moment there's two things:

  • Annotations are not sent automatically when running WebPageTest when Browsertime is disabled. It should but I cannot see them. Let me debug that.
  • We cannot get the image from the WebPageTest server. The log is filled with messages like: WARN: Couldn't get screenshot for id 190828_0F_a7049b18fbc27a44d975bed0d0268d52, run 2 from the WebPageTest API with the error Not Found (url = https://www.wikipedia.beta.wmflabs.org/) - I think this is a upstream issue in WebPageTest but also thinking maybe our server instance is too small and cannot handle the API load? Let me create a upstream issue later today.

Event Timeline

Disabling full screenshots on the WebPageTest server fixed the problem and I also created an upstream issue: https://github.com/WPO-Foundation/webpagetest/issues/1295

The annotation works (https://github.com/sitespeedio/sitespeed.io/issues/2599) now.

Need to verify that we show the WebPageTest screenshot in the annotation, haven't been able to test that yet.

Screenshots work now. The thing to fix now is add some extra logic for different configurations for Chrome/Firefox. Right now we try to get the trace log for Firefox:

Couldn't get chrome trace for id 190829_D8_f03fb867842b7afd4c174525d0575d9a, run 2 from the WebPageTest API with the error: Not Found (url = https://en.wikipedia.org/wiki/Facebook)

Also we should break down the WebPageTest tests into multiple files (per domain), that way the result is sent faster to S3 (annotations in Grafana will look better) and it will be easier for users to add more URLs.

I've fixed them last week, looks good now.