Page MenuHomePhabricator

Move Suggested edits menu item to main tab bar
Open, NormalPublic2 Story Points

Description

To improve the feature’s visibility, we’re moving Suggested edits to the main tab bar navigation for all logged in users. The SE tab won't be shown for logged-out users.

Also includes taking SE out of the hamburger menu since it's no longer an overflow item.

[note: does not include animation or notification - this is just about the tab bar]

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 28 2019, 12:52 PM
Charlotte triaged this task as Normal priority.Aug 29 2019, 5:07 PM
Charlotte updated the task description. (Show Details)
Charlotte set the point value for this task to 2.

@schoenbaechler @Charlotte How about when the user is not logged in?

The Suggested edits tab won't be shown for logged-out users @Sharvaniharan...

ABorbaWMF added a subscriber: ABorbaWMF.

Looks good to me on tablet and phone on 2.7.50300-alpha-2019-10-19

The “Suggested edits” label is cut off on my Pixel 3 (Android 10, Wikipedia `2.7.50300-alpha-2019-10-10). Moving this back to “Did not pass QA” for now.

@schoenbaechler looks like we might have to wait for the stable release. Looks like google is tracking this issue: https://issuetracker.google.com/issues/115754572.

I used the unstable beta version and here is the problem with using the beta: https://github.com/wikimedia/apps-android-wikipedia/pull/697