Page MenuHomePhabricator
Create Task
Maniphest T231540

Unable to view contributions: Call to undefined method ContribsPager::getContribs()
Closed, ResolvedPublic
Actions

Description

Steps to reproduce:
Visit https://en.wikipedia.beta.wmflabs.org/wiki/Special:Contributions/DannyS712 (or any other user)

Error:

PHP fatal error: 
Call to undefined method ContribsPager::getContribs()

Details

ProjectBranchLines +/-Subject
mediawiki/coremaster+0 -10ContribsPage: Re-remove the getContribs() method
mediawiki/extensions/Flowmaster+7 -65ContributionsQuery: Drop 'newbies' feature support, killed in core
mediawiki/coremaster+10 -0ContribsPage: bring back getContribs() method
Customize query in gerrit

Related Objects
Search...

Event Timeline

DannyS712 created this task.Aug 29 2019, 11:15 AM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptAug 29 2019, 11:15 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DannyS712 triaged this task as Unbreak Now! priority.Aug 29 2019, 11:15 AM
DannyS712 added a project: Platform Engineering.
Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptAug 29 2019, 11:15 AM
DannyS712 added a project: MediaWiki-Special-pages.Aug 29 2019, 11:16 AM
DannyS712 added subscribers: Jdforrester-WMF, dom_walden.Aug 29 2019, 11:19 AM

Likely caused by https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/527626/ part of T220447: Split out or remove Special:Contributions/newbies functionality - the function wasa simply removed ( https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/527626/6/includes/specials/pagers/ContribsPager.php )

Mainframe98 added a parent task: T220746: 1.34.0-wmf.21 deployment blockers.Aug 29 2019, 11:19 AM
DannyS712 added a comment.EditedAug 29 2019, 11:22 AM

Codesearch (https://codesearch.wmflabs.org/search/?q=getContribs%5C(&i=nope&files=&repos=) reveals calls to ContribsPager::getContribs from ArticleFeedbackv5 and StructuredDiscussions

daniel added a project: Platform Team Workboards (Clinic Duty Team).Aug 29 2019, 4:22 PM
daniel removed a project: Platform Engineering.Aug 29 2019, 4:23 PM
gerritbot added a comment.Aug 29 2019, 6:01 PM

Change 533280 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] ContribsPage: bring back getContribs() method (UBN)

https://gerrit.wikimedia.org/r/533280

gerritbot added a project: Patch-For-Review.Aug 29 2019, 6:01 PM
daniel moved this task from Inbox to Waiting for Review on the Platform Team Workboards (Clinic Duty Team) board.Aug 29 2019, 6:05 PM
DannyS712 assigned this task to daniel.Aug 29 2019, 6:07 PM
gerritbot added a comment.Aug 29 2019, 7:27 PM

Change 533306 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/Flow@master] ContributionsQuery: Drop 'newbies' feature support, killed in core

https://gerrit.wikimedia.org/r/533306

gerritbot added a comment.Aug 29 2019, 7:42 PM

Change 533280 merged by jenkins-bot:
[mediawiki/core@master] ContribsPage: bring back getContribs() method

https://gerrit.wikimedia.org/r/533280

DannyS712 closed this task as Resolved.Aug 29 2019, 7:57 PM

Thanks for the fix @daniel - once flow and article feedback are patched I'll upload a revert

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.21; 2019-09-03).Aug 29 2019, 8:00 PM
gerritbot added a comment.Aug 29 2019, 8:22 PM

Change 533325 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Revert "ContribsPage: bring back getContribs() method"

https://gerrit.wikimedia.org/r/533325

daniel moved this task from Waiting for Review to Done on the Platform Team Workboards (Clinic Duty Team) board.Aug 30 2019, 7:14 AM
gerritbot added a comment.Aug 30 2019, 6:38 PM

Change 533306 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] ContributionsQuery: Drop 'newbies' feature support, killed in core

https://gerrit.wikimedia.org/r/533306

gerritbot added a comment.Aug 30 2019, 10:37 PM

Change 533325 merged by jenkins-bot:
[mediawiki/core@master] ContribsPage: Re-remove the getContribs() method

https://gerrit.wikimedia.org/r/533325

Maintenance_bot removed a project: Patch-For-Review.Aug 30 2019, 11:10 PM
DannyS712 moved this task from Unsorted to Merged on the User-DannyS712 board.Sep 24 2019, 5:38 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL