Page MenuHomePhabricator
Create Task
Maniphest T231549

Payment submethod logos should have alt text
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

On payments forms e.g. Ingenico credit card, the submethod logos (visa, mastercard etc.) should have corresponding alt text attributes. This will improve accessibility for visually impaired users.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Card alt text: include when translatedmediawiki/extensions/DonationInterfacemaster+1 -1
Customize query in gerrit

Event Timeline

Pcoombe created this task.Aug 29 2019, 12:57 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 29 2019, 12:57 PM
Pcoombe moved this task from Unsorted to Attributes on the Accessibility board.Aug 29 2019, 12:57 PM
gerritbot added a comment.Aug 29 2019, 2:14 PM

Change 533228 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@master] Card alt text: include when translated

https://gerrit.wikimedia.org/r/533228

gerritbot added a project: Patch-For-Review.Aug 29 2019, 2:14 PM
Ejegg claimed this task.Aug 29 2019, 2:14 PM
Ejegg triaged this task as Medium priority.
Ejegg added a project: Fundraising Sprint Quick and the Deadlocked.
Ejegg set the point value for this task to 1.
Ejegg moved this task from Triage to Current Sprint on the Fundraising-Backlog board.
Ejegg moved this task from Backlog to Review on the Fundraising Sprint Quick and the Deadlocked board.
Ejegg moved this task from Review to Pending Deployment on the Fundraising Sprint Quick and the Deadlocked board.Aug 29 2019, 2:47 PM
gerritbot added a comment.Aug 29 2019, 3:23 PM

Change 533228 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Card alt text: include when translated

https://gerrit.wikimedia.org/r/533228

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.21; 2019-09-03).Aug 29 2019, 4:00 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 29 2019, 4:10 PM
Ejegg moved this task from Pending Deployment to Deployed on the Fundraising Sprint Quick and the Deadlocked board.Aug 29 2019, 11:25 PM
Ejegg added a comment.Aug 29 2019, 11:29 PM

Thanks for spotting this @Pcoombe. We had a token in the template for the alt text, but it never got updated when we added localized labels / titles for the li tags. Alt attributes should now have the text as well.

Pcoombe closed this task as Resolved.Aug 30 2019, 10:24 AM

Wonderful, thanks for fixing so quickly!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits