[XWfLKQpAAEEAAInM7PIAAADG] /w/index.php?associated=1&namespace=1%20waitfor%20delay%20'0:0:10'%20--%20&tagfilter=17&title=Spezial:Letzte%20%c3%84nderungen   ErrorException from line 165 of /srv/mediawiki/php-1.34.0-wmf.19/includes/title/NamespaceInfo.php: PHP Notice: A non well formed numeric value encountered

Impact

Line 165 42 hits, line 180 16 hits, line 246 15 hits so far in wmf.19, not seen before that.

Notes

Three errors seem connected. The only difference I can see is line number (165, 180, 246):

message

[{exception_id}] {exception_url} ErrorException from line 165 of /srv/mediawiki/php-1.34.0-wmf.19/includes/title/NamespaceInfo.php: PHP Notice: A non well formed numeric value encountered

message

[{exception_id}] {exception_url} ErrorException from line 246 of /srv/mediawiki/php-1.34.0-wmf.19/includes/title/NamespaceInfo.php: PHP Notice: A non well formed numeric value encountered

message

[{exception_id}] {exception_url} ErrorException from line 180 of /srv/mediawiki/php-1.34.0-wmf.19/includes/title/NamespaceInfo.php: PHP Notice: A non well formed numeric value encountered

Details

Request ID: XWfLKQpAAEEAAInM7PIAAADG
Request URL: bar.wikipedia.org/w/index.php?associated=1&namespace=1%20waitfor%20delay%20'0:0:10'%20--%20&tagfilter=17&title=Spezial:Letzte%20%c3%84nderungen

Stack Trace

trace

#0 /srv/mediawiki/php-1.34.0-wmf.19/includes/title/NamespaceInfo.php(165): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.34.0-wmf.19/includes/title/NamespaceInfo.php(245): NamespaceInfo->isTalk(string)
#2 /srv/mediawiki/php-1.34.0-wmf.19/includes/title/NamespaceInfo.php(276): NamespaceInfo->getSubject(string)
#3 /srv/mediawiki/php-1.34.0-wmf.19/includes/specialpage/ChangesListSpecialPage.php(1510): NamespaceInfo->getAssociated(string)
#4 [internal function]: ChangesListSpecialPage->{closure}(string)
#5 /srv/mediawiki/php-1.34.0-wmf.19/includes/specialpage/ChangesListSpecialPage.php(1516): array_map(Closure, array)
#6 /srv/mediawiki/php-1.34.0-wmf.19/includes/specialpage/ChangesListSpecialPage.php(996): ChangesListSpecialPage->buildQuery(array, array, array, array, array, FormOptions)
#7 /srv/mediawiki/php-1.34.0-wmf.19/includes/specialpage/ChangesListSpecialPage.php(629): ChangesListSpecialPage->getRows()
#8 /srv/mediawiki/php-1.34.0-wmf.19/includes/specials/SpecialRecentChanges.php(165): ChangesListSpecialPage->execute(NULL)
#9 /srv/mediawiki/php-1.34.0-wmf.19/includes/specialpage/SpecialPage.php(571): SpecialRecentChanges->execute(NULL)
#10 /srv/mediawiki/php-1.34.0-wmf.19/includes/specialpage/SpecialPageFactory.php(582): SpecialPage->run(NULL)
#11 /srv/mediawiki/php-1.34.0-wmf.19/includes/MediaWiki.php(296): MediaWiki\Special\SpecialPageFactory->executePath(Title, RequestContext)
#12 /srv/mediawiki/php-1.34.0-wmf.19/includes/MediaWiki.php(892): MediaWiki->performRequest()
#13 /srv/mediawiki/php-1.34.0-wmf.19/includes/MediaWiki.php(523): MediaWiki->main()
#14 /srv/mediawiki/php-1.34.0-wmf.19/index.php(42): MediaWiki->run()
#15 /srv/mediawiki/w/index.php(3): require(string)
#16 {main}

Related Objects

Mentioned In: T237067: "PHP Notice: A non well formed numeric value encountered" from DmsCoordinateParser.php in API action=wbparsevalue [Story Points 5]
Mentioned Here: T253098: "PHP Warning: A non-numeric value encountered" from NamespaceInfo.php via SpecialRecentChanges.php - NamespaceInfo::isTalk called with non-integer (string) namespace '-1'
T231548: NamespaceInfo.php: PHP Warning: A non-numeric value encountered

Event Timeline

• zeljkofilipin created this task.Aug 29 2019, 1:10 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 29 2019, 1:10 PM

• zeljkofilipin added a parent task: T220745: 1.34.0-wmf.20 deployment blockers.Aug 29 2019, 1:10 PM

• zeljkofilipin added a parent task: T231579: PHP Notice: A non well formed numeric value encountered.Aug 29 2019, 4:17 PM

Removed from train blockers since it only happened in wmf.19.

• zeljkofilipin removed a parent task: T220745: 1.34.0-wmf.20 deployment blockers.Aug 29 2019, 4:40 PM

Krinkle added a project: Platform Engineering.Aug 29 2019, 6:38 PM

Krinkle merged a task: T231548: NamespaceInfo.php: PHP Warning: A non-numeric value encountered.

Krinkle updated the task description. (Show Details)

Krinkle added subscribers: Simetrical, daniel.

ChangesListSpecialPage is not validating the parameters. It's assuming that the namespace parameter in the query string is a semicolon-delimited list of numbers. The URL here is invalid, and has garbage after the namespace parameter:

namespace=1%20waitfor%20delay%20'0:0:10'%20--%20

This will be parsed to int(1), which is probably correct, but it issues a notice.

The question is if we want to deal with bogus input differently from this. The notice is not really interesting, so we could just suppress it by explicitly casting to int. Or, we could abort. I think aborting isn't warranted here, because sometimes garbage does sneak into URLs (e.g., adjoining punctuation that gets included in an autolink). Probably it's best to silence the notice and continue.

From a quick look, it seems like ChangesListSpecialQuery was feeding bad values to NamespaceInfo. This appears to have been fixed since by adding the expandSymbolicNamespaceFilters( $namespaces ) method.

Fixed on master, closing.

Untagging CPT, tagging Growth, since ChangesListSpecialQuery is theirs.

@Simetrical it seems like the introduction of expandSymbolicNamespaceFilters() has fixed this, since it filters out unknown namespaces.

In general, NamespaceInfo should complain about bad input. It could even fail hard and throw an Invalid ArgumentException. Validating parameters is up to the frontend code, that is, the code that is processing form input. ChangesListSpecialQuery should check the parameters and complain to the user.

Re-opening, in case Growth-Team wants to follow up on the validation.

Tagging this to follow up in Q2, possibly.

Krinkle removed a parent task: T231579: PHP Notice: A non well formed numeric value encountered.Sep 17 2019, 4:07 PM

Krinkle moved this task from Untriaged to Aug2019/1.34.wmf.17+ on the Wikimedia-production-error board.

brennen mentioned this in T237067: "PHP Notice: A non well formed numeric value encountered" from DmsCoordinateParser.php in API action=wbparsevalue [Story Points 5].Oct 31 2019, 11:01 PM

Umherirrender moved this task from Aug2019/1.34.wmf.17+ to Resolved on the Wikimedia-production-error board.Nov 29 2019, 8:56 PM

Krinkle removed a project: Wikimedia-production-error.Apr 29 2020, 7:05 PM

• zeljkofilipin unsubscribed.Apr 30 2020, 10:01 AM

This seems to be happening again, per T231551: "PHP Notice: A non well formed numeric value encountered" from NamespaceInfo on Special:RecentChanges. Not sure how to reproduce though.

MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 6:51 PM

Removing task assignee due to inactivity, as this open task has been assigned for more than two years. See the email sent to the task assignee on February 06th 2022 (and T295729).

Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome.

If this task has been resolved in the meantime, or should not be worked on ("declined"), please update its task status via "Add Action… 🡒 Change Status".

Also see https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator.

Krinkle renamed this task from NamespaceInfo.php: PHP Notice: A non well formed numeric value encountered to "PHP Notice: A non well formed numeric value encountered" from NamespaceInfo on Special:RecentChanges.Mar 28 2025, 3:24 AM

Restricted Application added a project: Wikimedia-production-error. · View Herald TranscriptMar 28 2025, 3:24 AM

In T231551#6147614, @Nikerabbit wrote:

This seems to be happening again, per T231551: "PHP Notice: A non well formed numeric value encountered" from NamespaceInfo on Special:RecentChanges. Not sure how to reproduce though.

This refers to itself. I believe you meant T253098, which looks like a duplicate. However, given that one was fixed, I'll mark this one as duplicate instead,

Krinkle closed this task as a duplicate of T253098: "PHP Warning: A non-numeric value encountered" from NamespaceInfo.php via SpecialRecentChanges.php - NamespaceInfo::isTalk called with non-integer (string) namespace '-1'.Mar 28 2025, 3:27 AM

"PHP Notice: A non well formed numeric value encountered" from NamespaceInfo on Special:RecentChangesClosed, DuplicatePublicPRODUCTION ERRORActions

Description

Error

Impact

Notes

Details

Related Objects

Event Timeline

"PHP Notice: A non well formed numeric value encountered" from NamespaceInfo on Special:RecentChanges
Closed, DuplicatePublicPRODUCTION ERROR
Actions