Maniphest T231570

DomSourceRange serializes with null entries
Open, MediumPublic
Actions

Assigned To

None

Authored By

	Arlolra
	Aug 29 2019, 3:40 PM

Tags

Referenced Files

None

Subscribers

Description

For example, data-parsoid='{\"dsr\":[147,147,null,null]}'

We should consider dropping the openWidth/closeWidth when they aren't present.

See the discussion at https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/530980/19/tests/parserTests-php-blacklist.json#602

Related Objects

Mentioned In: T234979: Tracking task for addressing HTML string diffs between Parsoid/JS & Parsoid/PHP

Event Timeline

Arlolra created this task.Aug 29 2019, 3:40 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 29 2019, 3:40 PM

ssastry moved this task from Backlog to Deployment on the Parsoid-PHP board.Sep 3 2019, 7:09 PM

ssastry moved this task from Deployment to Post-Port Work on the Parsoid-PHP board.

ssastry moved this task from Post-Port Work to Porting Tech Debt Redressal on the Parsoid-PHP board.Sep 11 2019, 6:08 PM

ssastry mentioned this in T234979: Tracking task for addressing HTML string diffs between Parsoid/JS & Parsoid/PHP.Oct 9 2019, 5:19 PM

Arlolra triaged this task as Medium priority.Oct 11 2019, 11:30 PM

Aklapper edited projects, added Parsoid; removed Parsoid-PHP.Apr 10 2020, 4:27 PM

ssastry moved this task from Needs Triage to Bugs & Crashers on the Parsoid board.Apr 10 2020, 4:58 PM

There's a bit of an analysis / discussion of what it means for the open / close widths to be null in,
https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/606035/3/src/Wt2Html/PP/Handlers/DisplaySpace.php#13

since calls to innerStart/End coalesce them to 0 but they fail an isValid check.

ssastry moved this task from Bugs & Crashers to Tech Debt / Big changes on the Parsoid board.Jul 16 2020, 3:57 AM