Page MenuHomePhabricator

Deploy Special:Mute features
Open, NormalPublic2 Story Points

Description

This task is for keeping track of Special:Mute features deployment.

As a reminder, here are the features we added:

Let's enable the feature on the following (one by one with a week in between each, at least)

  • All beta wikis (except eswiki)
  • Testwiki
  • Commons and Wikidata
  • Non-Wikipedias
  • Wikipedias

We should make sure:

  • The features added work as expected in different languages
  • The features added work as expected in wikibase betas (commons and wikidata beta wikis)
  • Features work as expected with Globalprefs enabled
  • Eventlogging works as expected
  • Translations are coming in (we probably won't have them all yet)

Event Timeline

Niharika created this task.Aug 29 2019, 4:05 PM
Restricted Application added subscribers: MGChecker, Aklapper. · View Herald TranscriptAug 29 2019, 4:05 PM
Niharika triaged this task as Normal priority.Aug 29 2019, 4:17 PM
Niharika added a project: Epic.
Niharika updated the task description. (Show Details)
Niharika updated the task description. (Show Details)Sep 5 2019, 5:32 PM
Niharika set the point value for this task to 2.Sep 5 2019, 6:24 PM
dmaza claimed this task.Sep 16 2019, 6:25 PM

Change 538063 had a related patch set uploaded (by Dmaza; owner: Dmaza):
[operations/mediawiki-config@master] Enable SpecialMute feature on testwiki and beta cluster

https://gerrit.wikimedia.org/r/538063

Change 538063 merged by jenkins-bot:
[operations/mediawiki-config@master] Enable SpecialMute feature on testwiki and beta cluster

https://gerrit.wikimedia.org/r/538063

Mentioned in SAL (#wikimedia-operations) [2019-09-19T21:37:48Z] <niharika29@deploy1001> Synchronized wmf-config/VariantSettings.php: Enable special:mute on testwiki; T231577 (duration: 00m 56s)

Niharika added a subscriber: dom_walden.

@dom_walden Adding this to your column for now. Special:Mute is now deployed on all beta wikis except the eswiki beta (so you have a wiki where it is not enabled to test against). It is also on test.wikipedia.org.
Once you give the go-ahead, we can deploy this to more wikis.

Niharika updated the task description. (Show Details)Mon, Sep 30, 5:53 PM

Testing on:

  • The features added work as expected in different languages

Adds and removes a user from the email and notification blacklists

  • The features added work as expected in wikibase betas (commons and wikidata beta wikis)

Not on Commons or Wikidata yet.

  • Features work as expected with Globalprefs enabled

If email notifications are global, Special:Mute does not override this setting. If you have set a local override, then it does.

  • Eventlogging works as expected

Events appeared to be logged correctly on beta. I could not see the event log on test (I don't believe I have access).

@Niharika One interesting thing, which I did not notice before. If I have email or echo notification blacklists as a global setting and I try to use Special:Mute to change them, the event log will log the change as if it were successful, when it is not.

Logging, for example:

...
 "event": {
    "emailsAfter": true,
    "emailsBefore": false,
...

When in fact the email blacklist has not been changed because it is a global setting.

It might be OK to log the user's desire to mute/unmute someone, regardless of whether it has been successful. Then again, if the user thinks it is broken and keeps retrying then the statistics might be skewed.

  • Translations are coming in (we probably won't have them all yet)

On Dutch beta Wikipedia, appears to be translated into Dutch (cannot say if it is correct)

dbarratt closed this task as Resolved.Wed, Oct 2, 7:55 PM
Niharika reopened this task as Open.Fri, Oct 4, 6:07 PM
Niharika moved this task from Done to QA/Testing on the Anti-Harassment (The Letter Song) board.
Niharika added a subscriber: dbarratt.

@dbarratt This task is more like a "rolling task" for deploying Special:Mute everywhere. It is only on betas and testwiki for now.

Testing on:

  • The features added work as expected in different languages

Adds and removes a user from the email and notification blacklists

  • The features added work as expected in wikibase betas (commons and wikidata beta wikis)

Not on Commons or Wikidata yet.

Oh I meant on https://commons.wikimedia.beta.wmflabs.org and https://wikidata.beta.wmflabs.org/

  • Features work as expected with Globalprefs enabled

If email notifications are global, Special:Mute does not override this setting. If you have set a local override, then it does.

Interesting. I would expect the username to be added to the global list per our work in T224245: Create a way to save preference options wherever they are set by GlobalPreferences without disruption and per T224245#5314103 it did work. I think we just forgot to add the config to our beta cluster. Does that seem right, @dom_walden?

  • Eventlogging works as expected

Events appeared to be logged correctly on beta. I could not see the event log on test (I don't believe I have access).
@Niharika One interesting thing, which I did not notice before. If I have email or echo notification blacklists as a global setting and I try to use Special:Mute to change them, the event log will log the change as if it were successful, when it is not.
Logging, for example:

...
 "event": {
    "emailsAfter": true,
    "emailsBefore": false,
...

When in fact the email blacklist has not been changed because it is a global setting.
It might be OK to log the user's desire to mute/unmute someone, regardless of whether it has been successful. Then again, if the user thinks it is broken and keeps retrying then the statistics might be skewed.

I believe this will be fixed with the above global settings fix.

  • Translations are coming in (we probably won't have them all yet)

On Dutch beta Wikipedia, appears to be translated into Dutch (cannot say if it is correct)

@dbarratt This task is more like a "rolling task" for deploying Special:Mute everywhere. It is only on betas and testwiki for now.

That's fine, I only marked it _Resolved_ because it was moved to the _Done_ column.

Oh, sorry I haven't tested those yet.

Interesting. I would expect the username to be added to the global list per our work in T224245: Create a way to save preference options wherever they are set by GlobalPreferences without disruption and per T224245#5314103 it did work. I think we just forgot to add the config to our beta cluster. Does that seem right, @dom_walden?

Yep.

Leaving this in until commons and wikidata betas have been tested.

The problems with global prefs should be fixed in beta with https://gerrit.wikimedia.org/r/#/c/operations/mediawiki-config/+/542644/
@Tchanders - I made the config patch ^, don't worry about it. :)

Retested on https://commons.wikimedia.beta.wmflabs.org and https://wikidata.beta.wmflabs.org.

Email and notification mute preferences can now be set globally from Special:Mute (if they are enabled globally on Special:GlobalPreferences).

Briefly tested that the muting of users from emails and notifications works on those environments.

Thanks @dom_walden. I'll prioritize this for wider deployment. Replacing this in the Ready column for that.