Page MenuHomePhabricator

[SPIKE] Investigate login issues
Closed, ResolvedPublic

Description

  • Figure out when issues started by looking at OTRS tickets
  • Investigate root cause of issues
  • Make suggestions for fixing

Timebox: 1/2 day

Event Timeline

Note: sent a beta APK with new RxJava login logic to users who have login token issue.

Update: the RxJava login logic does not solve the issue since both of the users reported the same "login token" message.

Note: sent a beta APK version of storing and displaying the "login token" to the users to see if it actually sends a null logintoken when logging in.

It will show as the following screenshot:

Screenshot_1567551536.png (2×1 px, 96 KB)

Figure out when issues started by looking at OTRS tickets

Does not have a clear clue about when it starts happening since the reported login issues were either related to crashes or a brief message like "an error occurs"

Investigate root cause of issues

Still not sure how it happens.

Update:
(https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=11149624#13345434)
User replied with a screenshot, which actually got a null login token:

Screenshot_20190904-121217.jpg (1×1 px, 96 KB)

and, here's the information from the user:

I have a OnePlus 3T, rooted with magisk and Adaway (ad blocker).

We still don't have a clear path of how to resolve the issue...

cooltey added subscribers: ABorbaWMF, Dbrant.

Thanks @Dbrant found a solution for the issue: https://github.com/wikimedia/apps-android-wikipedia/pull/624

As the note in this patch:

NOTE: We still need to test whether actual 2FA is still working after this patch.

@ABorbaWMF Please help to test the 2FA if it works as expected.