Replace 24x24px SVGs in MF/Minerva
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

Authored By

	• alexhollender_WMF
	Aug 29 2019, 10:42 PM

Description

This related to the work in T229440

Updated SVGs to be used

NOTE: there are currently two different User icons on the mobile site — the filled-in one used in the sidebar for logged-in (non-AMC) users, and the outlined one used in the header for AMC users. Only the filled-in one needs to be updated.

	ltr	rtl	status
Back/previous arrow	arrowPrevious-ltr.svg229 BDownload	arrowPrevious-rtl.svg225 BDownload	✅
Bytes added	byteChanges.svg309 BDownload	(same)	✅
Bytes removed	*use rotated Bytes added icon	(same)	✅
Bytes unchanged	*use rotated Bytes added icon	(same)	✅
Close/X	close.svg273 BDownload	(same)	✅
Edit	edit.svg275 BDownload	(same)	✅
Hamburger	menu.svg207 BDownload	(same)	✅
History	history.svg313 BDownload	(same)	✅
Home	home.svg250 BDownload	(same)	✅
Language	language.svg717 BDownload	(same)	✅
Log in	logIn-ltr.svg315 BDownload	logIn-rtl.svg320 BDownload	✅
Log out	logOut-ltr.svg256 BDownload	logOut-rtl.svg260 BDownload	✅
Nearby	mapPin.svg319 BDownload	(same)	✅
Random	die.svg405 BDownload	(same)	✅
Settings	settings.svg541 BDownload	(same)	✅
Search within page	search within page.svg439 BDownload	(same)	✅
Table of contents	contents-ltr.svg269 BDownload	contents-rtl.svg263 BDownload	✅
User	userAvatar.svg259 BDownload	(same)	✅
Watch	star.svg310 BDownload	(same)	✅
Watchlist	unStar.svg237 BDownload	(same)	✅
Stop watching	unStar.svg237 BDownload	(same)	✅

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
Update watchstar icon location	mediawiki/extensions/MobileFrontend	master	+18 -17
Remove watch and watched icons from repository in favor of Wikimedia UI	mediawiki/skins/MinervaNeue	master	+5 -13
Update MobileFrontend icons to WikimediaUI theme equivalents	mediawiki/extensions/MobileFrontend	master	+80 -81
Restore arrows to ImageCarousel	mediawiki/extensions/MobileFrontend	master	+25 -17
New table of contents icon, prepare for arrow->expand rename	mediawiki/skins/MinervaNeue	master	+18 -4
Use avatarIcon instead of profile	mediawiki/skins/MinervaNeue	master	+3 -3

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	ovasileva	T226562 AMC - display labels for toolbar actions on larger screens
Resolved	• alexhollender_WMF	T229440 [EPIC] Refactor icon sizing in MF/Minerva to achieve consistency
Resolved	• alexhollender_WMF	T231613 Replace 24x24px SVGs in MF/Minerva

Event Timeline

• alexhollender_WMF created this task.Aug 29 2019, 10:42 PM

• alexhollender_WMF mentioned this in T229440: [EPIC] Refactor icon sizing in MF/Minerva to achieve consistency.

ovasileva triaged this task as High priority.Aug 30 2019, 3:39 PM

ovasileva moved this task from Needs Analysis to Ready for Development on the Web-Team-Backlog-Archived (Readers-Web-Kanbanana-2019-20-Q1) board.Sep 3 2019, 4:12 PM

ovasileva moved this task from Ready for Development to Needs Analysis on the Web-Team-Backlog-Archived (Readers-Web-Kanbanana-2019-20-Q1) board.Sep 3 2019, 4:23 PM

ovasileva set the point value for this task to 3.

• alexhollender_WMF updated the task description. (Show Details)Sep 3 2019, 4:24 PM

• alexhollender_WMF removed the point value 3 for this task.

ovasileva set the point value for this task to 3.Sep 3 2019, 4:26 PM

Jdlrobson moved this task from Needs Analysis to Ready for Development on the Web-Team-Backlog-Archived (Readers-Web-Kanbanana-2019-20-Q1) board.Sep 3 2019, 5:07 PM

Jdlrobson moved this task from Needs triage to MinervaNeue on the Mobile board.Sep 4 2019, 4:10 PM

Jdlrobson claimed this task.Sep 4 2019, 7:55 PM

Jdlrobson moved this task from Ready for Development to Doing on the Web-Team-Backlog-Archived (Readers-Web-Kanbanana-2019-20-Q1) board.

Change 534529 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Update MobileFrontend icons to Wikimedia UI equivalents

https://gerrit.wikimedia.org/r/534529

gerritbot added a project: Patch-For-Review.Sep 4 2019, 8:49 PM

Patch above changes back and close icons.

Now need to look at close and user icons.

@alexhollender Does the "User" icon refer to:
http://en.m.wikipedia.beta.wmflabs.org/w/load.php?modules=wikimedia.ui&image=userAvatar&format=original&lang=en&skin=minerva
OR https://en.m.wikipedia.beta.wmflabs.org/w/load.php?modules=skins.minerva.icons.images&image=profile&format=original&lang=en&skin=minerva OR both OR something else? Are these icons the same (they are not for some reason in the codebase)?

here are the icons I see that could be called user icons

userAvatarOutline (top right) and profile (in menu):

Screenshot 2019-09-04 at 1.55.54 PM.png (112×280 px, 8 KB)

profile:

Screenshot 2019-09-04 at 1.56.50 PM.png (346×365 px, 20 KB)

userAvatar:

Screenshot 2019-09-04 at 1.56.05 PM.png (459×268 px, 26 KB)

Change 534535 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Use avatarIcon instead of profile and update logout icon

https://gerrit.wikimedia.org/r/534535

Jdlrobson moved this task from Doing to Needs Code Review on the Web-Team-Backlog-Archived (Readers-Web-Kanbanana-2019-20-Q1) board.Sep 4 2019, 9:11 PM

@Jdlrobson the filled user icon refers to these two:

The other one you referenced is soon to be changed per T230694

https://gerrit.wikimedia.org/r/534535 renames the icon called 'profile' in the code per Alex's instructions. It will now be called userAvatar.

Jdlrobson moved this task from Backlog to Misc on the MobileFrontend (MobileFrontend and MinervaNeue architecture) board.Sep 5 2019, 8:35 PM

Change 534535 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Use avatarIcon instead of profile

https://gerrit.wikimedia.org/r/534535

Restricted Repository Identity mentioned this in rSKIN0a97e66ac754: Update git submodules.Sep 5 2019, 9:29 PM

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.22; 2019-09-10); removed MW-1.34-notes (1.34.0-wmf.21; 2019-09-03).Sep 5 2019, 10:00 PM

• alexhollender_WMF updated the task description. (Show Details)Sep 6 2019, 3:11 PM

• alexhollender_WMF updated the task description. (Show Details)Sep 6 2019, 4:29 PM

Jdlrobson moved this task from Needs Code Review to Doing on the Web-Team-Backlog-Archived (Readers-Web-Kanbanana-2019-20-Q1) board.Sep 6 2019, 5:41 PM

Jdlrobson moved this task from Doing to Needs Code Review on the Web-Team-Backlog-Archived (Readers-Web-Kanbanana-2019-20-Q1) board.Sep 6 2019, 5:57 PM

Change 534865 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] New table of contents icon, prepare for arrow->expand rename

https://gerrit.wikimedia.org/r/534865

@Volker_E Note search within pages or TOC are not in Wikimedia UI

I'm seeing the following icon which is similar to the toc icon in Wikimedia UI. Should these icons be the same?

stripeToC-ltr-invert.svg245 BDownload

stripeSummary-rtl.svg

These icons will continue to use local definitions (https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/MinervaNeue/+/534865/)

@Jdlrobson Would you provide contextual screenshot of the toc icon?

Change 534865 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] New table of contents icon, prepare for arrow->expand rename

https://gerrit.wikimedia.org/r/534865

Restricted Repository Identity mentioned this in rSKIN47373a30d13f: Update git submodules.Sep 9 2019, 7:26 PM

Volker_E mentioned this in T232383: Consolidate MinervaNeue and Flow on one WikimediaUI icon for ToC.Sep 9 2019, 7:37 PM

Change 534529 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Update MobileFrontend icons to WikimediaUI theme equivalents

https://gerrit.wikimedia.org/r/534529

Maintenance_bot removed a project: Patch-For-Review.Sep 9 2019, 9:10 PM

I think this can skip QA, provided it has a design review from Alex.

All SVGS should listed now be updated and live on https://en.m.wikipedia.beta.wmflabs.org/wiki/Spain

Change 535960 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Restore arrows to ImageCarousel

https://gerrit.wikimedia.org/r/535960

gerritbot added a project: Patch-For-Review.Sep 11 2019, 11:06 PM

Change 535960 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Restore arrows to ImageCarousel

https://gerrit.wikimedia.org/r/535960

Jdlrobson removed a project: Patch-For-Review.Sep 12 2019, 12:03 AM

Jdlrobson mentioned this in T232941: [Regression] Showing "No change in size" wrongly on Minerva diff pages and text enlarged.Sep 16 2019, 5:10 PM

@Jdlrobson @Jdrewniak unless there's a caching issue it looks like Watch and Un-watch (which appear in the article toolbar) have not been updated yet. When inspecting them I see the old SVG.

In T231613#5500661, @alexhollender wrote:

@Jdlrobson @Jdrewniak unless there's a caching issue it looks like Watch and Un-watch (which appear in the article toolbar) have not been updated yet. When inspecting them I see the old SVG.

hmm looks like we have two icons - one in Minerva and one in MobileFrontend: .mw-ui-icon-minerva-watch and .mw-ui-icon-mf-watch
Which is the right one?
https://en.m.wikipedia.beta.wmflabs.org/w/load.php?modules=skins.minerva.icons.images&image=watch&format=original&skin=minerva
or https://en.m.wikipedia.beta.wmflabs.org/w/load.php?modules=mobile.startup.images&image=watch&format=rasterized&skin=minerva&version=1u9iy ?

• alexhollender_WMF updated the task description. (Show Details)Sep 17 2019, 8:00 PM

Jdlrobson moved this task from Needs More Work to Doing on the Web-Team-Backlog-Archived (Readers-Web-Kanbanana-2019-20-Q1) board.Sep 17 2019, 9:29 PM

@alexhollender should the star be blue or green? (it's easier if it's blue..)

Screenshot 2019-09-17 at 2.59.21 PM.png (431×370 px, 45 KB)

Change 537558 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Update watchstar icon location

https://gerrit.wikimedia.org/r/537558

Change 537559 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Remove watch and watched icons from repository in favor of Wikimedia UI

https://gerrit.wikimedia.org/r/537559

Jdlrobson assigned this task to • alexhollender_WMF.Sep 17 2019, 10:06 PM

Jdlrobson moved this task from Doing to Needs Design Review on the Web-Team-Backlog-Archived (Readers-Web-Kanbanana-2019-20-Q1) board.

In T231613#5501336, @Jdlrobson wrote:

@alexhollender should the star be blue or green? (it's easier if it's blue..)

Blue

Jdlrobson moved this task from Needs More Work to Needs Code Review on the Web-Team-Backlog-Archived (Readers-Web-Kanbanana-2019-20-Q1) board.Sep 17 2019, 11:10 PM

In T231613#5501598, @alexhollender wrote:

In T231613#5501336, @Jdlrobson wrote:

@alexhollender should the star be blue or green? (it's easier if it's blue..)

Blue

Exciting! :)

pmiazga moved this task from Needs Code Review to Needs More Work on the Web-Team-Backlog-Archived (Readers-Web-Kanbanana-2019-20-Q1) board.Sep 18 2019, 9:55 PM

Jdlrobson moved this task from Needs More Work to Needs Code Review on the Web-Team-Backlog-Archived (Readers-Web-Kanbanana-2019-20-Q1) board.Sep 19 2019, 5:13 PM

Change 538114 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Use core watchstar code

https://gerrit.wikimedia.org/r/538114

Change 537559 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Remove watch and watched icons from repository in favor of Wikimedia UI

https://gerrit.wikimedia.org/r/537559

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.24; 2019-09-24); removed MW-1.34-notes (1.34.0-wmf.22; 2019-09-10).Sep 20 2019, 7:00 PM

Change 537558 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Update watchstar icon location

https://gerrit.wikimedia.org/r/537558

Jdlrobson reassigned this task from Jdlrobson to • alexhollender_WMF.Sep 23 2019, 6:40 PM

Jdlrobson moved this task from Needs Code Review to Needs Design Review on the Web-Team-Backlog-Archived (Readers-Web-Kanbanana-2019-20-Q1) board.

@alexhollender blue watchstar should be live on the beta cluster shortly. It will ride train early tomorrow so please let me know today if there are any problems.
https://en.m.wikipedia.beta.wmflabs.org/wiki/Spain

In T231613#5517321, @Jdlrobson wrote:

@alexhollender blue watchstar should be live on the beta cluster shortly. It will ride train early tomorrow so please let me know today if there are any problems.
https://en.m.wikipedia.beta.wmflabs.org/wiki/Spain

Looks good. Not sure where it should go next.

• alexhollender_WMF updated the task description. (Show Details)Sep 23 2019, 10:13 PM

Jdlrobson moved this task from Needs Code Review to Ready for Signoff on the Web-Team-Backlog-Archived (Readers-Web-Kanbanana-2019-20-Q1) board.Sep 23 2019, 10:14 PM

@Jdlrobson, @alexhollender - have we tested the other SVGs? I think T231613#5500661 means that the rest are okay but wanted to confirm before signoff.

In T231613#5519027, @ovasileva wrote:

@Jdlrobson, @alexhollender - have we tested the other SVGs? I think T231613#5500661 means that the rest are okay but wanted to confirm before signoff.

Yes I went through an inspected all of them. I'm not sure it makes sense to do more QA on this one.

In T231613#5519549, @alexhollender wrote:

In T231613#5519027, @ovasileva wrote:

@Jdlrobson, @alexhollender - have we tested the other SVGs? I think T231613#5500661 means that the rest are okay but wanted to confirm before signoff.

Yes I went through an inspected all of them. I'm not sure it makes sense to do more QA on this one.

Perfect, resolving.

[batch] remove patch for review tag from resolved tasks

	F30382822: Screenshot 2019-09-17 at 2.59.21 PM.png
	Sep 17 2019, 9:59 PM

	F30224122: Screenshot 2019-09-04 at 1.56.05 PM.png
	Sep 4 2019, 8:58 PM

	F30229704: image.png
	Sep 5 2019, 12:48 PM

Replace 24x24px SVGs in MF/MinervaClosed, ResolvedPublic3 Estimated Story PointsActions

Description

Description

Updated SVGs to be used

Details

Related ObjectsSearch...

Event Timeline

Replace 24x24px SVGs in MF/Minerva
Closed, ResolvedPublic3 Estimated Story Points
Actions

Related Objects
Search...