Page MenuHomePhabricator
Create Task
Maniphest T231659

Switch to using the new validator framework for Open Street Map - Website project
Closed, ResolvedPublic
Actions

Description

Request - https://github.com/openstreetmap/openstreetmap-website/issues/2301#issuecomment-509257630

  • Confirm with community
  • Submit / patch
  • Deploy on Translatewiki.net
  • Summarize validators to be added

Plural validators will be added as part of a separate task.

Following validators are needed,

  1. Links - Only insertables
  2. Ruby Variables - Validator & Insertable
  3. HTML entities - Insertable
  4. html.direction Key - Can be one of - ltr OR rtl. Will need to add a new validator for this. Tracked under - T232084
  5. Plural insertables

Details

Due Date
Dec 30 2019, 6:30 PM
ProjectBranchLines +/-Subject
translatewikimaster+1 -0Add UnicodePlural validator for OpenStreetMap
translatewikimaster+8 -0Add validator for html direction for Open Street Map - Website
translatewikimaster+12 -64Add validators for OpenStreetMap - Website
Customize query in gerrit

Related Objects
Search...

Event Timeline

abi_ created this task.Aug 30 2019, 3:44 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 30 2019, 3:44 PM
abi_ added a parent task: T224025: Migrate existing projects to use the new Validator framework.Aug 30 2019, 3:44 PM
abi_ moved this task from Backlog to Priority backlog on the Language-Team (Language-2019-July-September) board.

This task has been created to break down the parent task T224025: Migrate existing projects to use the new Validator framework into smaller project level task.

abi_ moved this task from Backlog to Configuration changes on the translatewiki.net board.Aug 31 2019, 4:58 AM
abi_ claimed this task.Sep 5 2019, 7:25 AM
abi_ moved this task from Priority backlog to In Progress on the Language-Team (Language-2019-July-September) board.
abi_ updated the task description. (Show Details)Sep 5 2019, 11:07 AM
abi_ triaged this task as Medium priority.Sep 5 2019, 12:08 PM
gerritbot added a comment.Sep 5 2019, 3:12 PM

Change 534628 had a related patch set uploaded (by Abijeet Patro; owner: Abijeet Patro):
[translatewiki@master] Add validators for OpenStreetMap - Website

https://gerrit.wikimedia.org/r/534628

gerritbot added a project: Patch-For-Review.Sep 5 2019, 3:12 PM
gerritbot added a comment.Sep 11 2019, 12:34 PM

Change 534628 merged by jenkins-bot:
[translatewiki@master] Add validators for OpenStreetMap - Website

https://gerrit.wikimedia.org/r/534628

jenkins-bot mentioned this in rGTWN6c438bfb4c2d: Add validators for OpenStreetMap - Website.Sep 11 2019, 12:38 PM
abi_ updated the task description. (Show Details)Sep 12 2019, 2:00 PM
abi_ added a comment.EditedSep 12 2019, 4:06 PM

The following validators and insertables have been added and deployed,

  1. Links
  2. Ruby variables
  3. HTML entities

Pginer-WMF edited projects, added Language-Team (Language-2019-October-December); removed Language-Team (Language-2019-July-September).Oct 9 2019, 11:52 AM
Pginer-WMF moved this task from Backlog to In Progress on the Language-Team (Language-2019-October-December) board.
abi_ mentioned this in T231705: Limit validation to certain messages.Oct 26 2019, 1:49 PM
gerritbot added a comment.Nov 9 2019, 6:41 PM

Change 549979 had a related patch set uploaded (by Abijeet Patro; owner: Abijeet Patro):
[translatewiki@master] Add validator for html direction for Open Street Map - Website

https://gerrit.wikimedia.org/r/549979

abi_ set Due Date to Nov 30 2019, 6:30 PM.Nov 14 2019, 4:24 PM
abi_ changed Due Date from Nov 30 2019, 6:30 PM to Dec 30 2019, 6:30 PM.
abi_ moved this task from In Progress to In Review on the Language-Team (Language-2019-October-December) board.Dec 12 2019, 6:13 AM
gerritbot added a comment.Dec 18 2019, 3:11 PM

Change 549979 merged by jenkins-bot:
[translatewiki@master] Add validator for html direction for Open Street Map - Website

https://gerrit.wikimedia.org/r/549979

jenkins-bot mentioned this in rGTWN34e265e993bf: Add validator for html direction for Open Street Map - Website.Dec 18 2019, 3:11 PM
Pginer-WMF edited projects, added Language-Team (Language-2020-January-March); removed Language-Team (Language-2019-October-December).Jan 2 2020, 8:13 AM
Pginer-WMF moved this task from Backlog to In Review on the Language-Team (Language-2020-January-March) board.
gerritbot added a comment.Jan 5 2020, 11:20 AM

Change 562045 had a related patch set uploaded (by Abijeet Patro; owner: Abijeet Patro):
[translatewiki@master] Add UnicodePlural validator for OpenStreetMap

https://gerrit.wikimedia.org/r/562045

gerritbot added a comment.Jan 8 2020, 2:04 PM

Change 562045 merged by jenkins-bot:
[translatewiki@master] Add UnicodePlural validator for OpenStreetMap

https://gerrit.wikimedia.org/r/562045

jenkins-bot mentioned this in rGTWN26606bfb44ff: Add UnicodePlural validator for OpenStreetMap.Jan 8 2020, 2:06 PM
abi_ closed this task as Resolved.Jan 13 2020, 2:41 AM
abi_ removed a project: Patch-For-Review.
abi_ moved this task from In Review to Done on the Language-Team (Language-2020-January-March) board.

This has been deployed on translatewiki.net.

I did not notice any issues with the functionality.

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL