Page MenuHomePhabricator

[EPIC] Ensure all direct or indirect access to pre-MCR fields is gated with the MCR migration stage and emits a warning if any pre-MCR schema fields are accessed
Closed, ResolvedPublic

Description

Before switching purely to using the new MCR schema, we need to be sure we are not accessing the pre-MCR schema anywhere. In this step, we will make sure that all pre-MCR schema access is gated with SCHEMA_COMPAT_* bitfield values. These changes must be made in MediaWiki core and WMF-production and bundled extensions. These changes should be made or identified and maintainers notified in other extensions searched by code search.

.

Related Objects

StatusSubtypeAssignedTask
StalledNone
OpenNone
Resolveddaniel
ResolvedCCicalese_WMF
Resolveddaniel
ResolvedNone
ResolvedNone
ResolvedCCicalese_WMF
ResolvedCCicalese_WMF
Resolveddaniel
ResolvedPchelolo
Resolveddaniel
ResolvedBPirkle
ResolvedPchelolo
ResolvedClarakosi
Resolveddaniel
ResolvedPchelolo
ResolvedPchelolo
ResolvedPchelolo
ResolvedPchelolo
ResolvedPchelolo
Resolveddaniel
Resolveddaniel
Resolvedholger.knust
ResolvedPchelolo
ResolvedNone
ResolvedNone
Resolveddaniel

Event Timeline

CCicalese_WMF triaged this task as Medium priority.Aug 30 2019, 5:34 PM
CCicalese_WMF created this task.

@daniel, you now have the epic as a subtask of the user story. It should be the other way around. Are we missing an engineering task here?

daniel added a comment.Oct 9 2019, 2:37 PM

@daniel, you now have the epic as a subtask of the user story. It should be the other way around. Are we missing an engineering task here?

The confusion arises from the following:

  1. we want to remove all *known* access to deprecated stuff
  2. only after we have done that, we want to trigger warnings.
  3. if the warnings get triggered, we know that we have been successful.

(1) and (3) are easy to confuse if we are not careful about the wording. Maybe I got them mixed up. I suppose (1) is an engineering task, and (3) is a story or epic.

I think the problem is confusion between this task, T231671 (epic), and T231693 (user story). They are both named similarly. The epic has other user stories, including T231699, which you moved from a subtask to a parent task of this epic task. I will swap them back and rename the epic to make it clear it includes the requirement of a warning.

CCicalese_WMF renamed this task from Ensure all direct or indirect access to pre-MCR fields is gated with the MCR migration stage to Ensure all direct or indirect access to pre-MCR fields is gated with the MCR migration stage and emits a warning if any pre-MCR schema fields are accessed.Oct 9 2019, 4:15 PM
CCicalese_WMF renamed this task from Ensure all direct or indirect access to pre-MCR fields is gated with the MCR migration stage and emits a warning if any pre-MCR schema fields are accessed to [EPIC] Ensure all direct or indirect access to pre-MCR fields is gated with the MCR migration stage and emits a warning if any pre-MCR schema fields are accessed.