Page MenuHomePhabricator

Remove concept of "large" icon in MF/Minerva
Closed, ResolvedPublic3 Estimated Story Points



This is part of the icon refactoring effort T229440. Initially we thought it made sense to create three standard icon sizes: small, medium, and large. However our audit showed that there is not currently any sensible standard for "large". The few icons we've found that are larger than "medium" range from 40x40px to 275x175px, and in some cases are more like images/graphics than icons. We don't see value in creating a standard at this time.

icons in the interface that are larger than "medium" (20x20px)
image.png (739×1 px, 483 KB)

QA steps

We'll want to verify we see icons on the following pages:

QA Results

Event Timeline

ovasileva triaged this task as Medium priority.Sep 3 2019, 9:36 AM
ovasileva set the point value for this task to 3.Sep 3 2019, 4:16 PM

Change 534607 had a related patch set uploaded (by Jdrewniak; owner: Jdrewniak):
[mediawiki/extensions/MobileFrontend@master] Remove "large" icons

Change 534607 merged by Jdlrobson:
[mediawiki/extensions/MobileFrontend@master] Remove "large" icons

Edtadros subscribed.

Test Result

Status: ✅ PASS
OS: macOS Mojave
Browser: Chrome
Device: MBP
Emulated Device: iPhoneX

Test Artifact(s):

QA steps

✅ AC1:

T231683-1.png (2×1 px, 183 KB)

✅ AC2: (log in as a new user with an empty watchlist)
T231683-2.png (2×1 px, 295 KB)

✅ AC3: Perform a search for Sp - make sure thumbnails show for articles without images. Search for Spain to see some results which do have images

T231683-3.png (2×1 px, 169 KB)
T231683-3b.png (2×1 px, 405 KB)

✅ AC4: Trigger AMC (incognito window as account with AMC disabled) and make sure the AMC graphic is still showing{F30282789}

T231683-4.png (2×1 px, 321 KB)

DannyS712 subscribed.

[batch] remove patch for review tag from resolved tasks