| abi_ | |
| Aug 31 2019, 5:11 AM |
| F31480801: image.png | |
| Dec 18 2019, 4:43 PM |
Currently limiting the validator to only certain messages is not possible without PHP code. We should consider whether we can add a message key matching support.
In this case the insertables will also be only displayed for those messages.
Example: https://gerrit.wikimedia.org/r/c/translatewiki/+/524669
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Add support to limit validations to certain messages | mediawiki/extensions/Translate | master | +123 -12 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T195760 Language Annual Plan 2018-2019 | |||
| Resolved | Nikerabbit | T204818 Language tools maintenance intervention: Improve the quality of translations for Translate extension | |||
| Resolved | abi_ | T204568 Extend message checker framework to support errors that prevent saving | |||
| Open | None | T231704 Improving the new validator framework | |||
| Resolved | abi_ | T231705 Limit validation to certain messages |
Planning to add support with the following syntax,
# Eg 1: For a specific message key. VALIDATORS: - id: InsertableRegex enforce: true insertable: true params: regex: /\$[a-z0-9]+/ message: abc # Eg 2: For a regular expression for keys VALIDATORS: - id: InsertableRegex enforce: true insertable: true params: regex: /\$[a-z0-9]+/ message: regex: /\[a-z]/ # Eg 3: For a set of message keys VALIDATORS: - id: InsertableRegex enforce: true insertable: true params: regex: /\$[a-z0-9]+/ messages: - abc - xyz
After discussing with Niklas, following is the structure we've come up with,
--- # This syntax can handle a specific message key / regex / multiple keys. VALIDATORS: - id: InsertableRegex enforce: true insertable: true params: regex: /\$[a-z0-9]+/ messages: - abc - xyz - type: regex pattern: /\[a-z]/
(Edited after another discussion)
Change 546351 had a related patch set uploaded (by Abijeet Patro; owner: Abijeet Patro):
[mediawiki/extensions/Translate@master] Add support to limit validations to certain messages
Change 546351 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Add support to limit validations to certain messages
This has been deployed to Translatewiki.net but currently the way to test this would be to merge and deploy this patch - https://gerrit.wikimedia.org/r/c/translatewiki/+/549979
In this patch, we check that the html.direction message for OpenStreetMap can only have value ltr and rtl
We've deployed this on translatewiki.net. For OpenStreetMap, the valid values for the html.direction message has been set to ltr, rtl.
