Page MenuHomePhabricator

Rename `AbuseFilterDisallowGlobalLocalBlocks` to `AbuseFilterDisallowGlobalLocalRestricted`
Closed, DuplicatePublic

Description

AbuseFilterDisallowGlobalLocalBlocks is used in AbuseFilterRunner.php to filter out more than just blocks:

AbuseFilterRunner.php
if ( $wgAbuseFilterDisallowGlobalLocalBlocks && $isGlobalFilter ) {
	$actions = array_diff_key( $actions, array_filter( $wgAbuseFilterRestrictions ) );
}

the name should reflect its actual usage. AbuseFilterDisallowGlobalLocalBlocks is not changed in WMF config, so there are no complications with switching it over (for external sites, this would invalidate current restrictions, but wouldn't necessarily break anything)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 533624 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/AbuseFilter@master] Rename AbuseFilterDisallowGlobalLocalBlocks to AbuseFilterDisallowGlobalLocalRestricted

https://gerrit.wikimedia.org/r/533624

Change 533624 abandoned by Krinkle:
Rename AbuseFilterDisallowGlobalLocalBlocks to AbuseFilterDisallowGlobalLocalRestricted

Reason:
Closing in favour of https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/AbuseFilter/ /462123/

https://gerrit.wikimedia.org/r/533624