Page MenuHomePhabricator

mw.config wgRevisionId return 0 with diffonly=1
Open, Needs TriagePublic

Description

The doc said "The revision ID of ... the right revision for diff views.".
But when you enable preferences "Do not show page content below diffs" or use url diffonly=1, this variable return 0.
Compare following two links:

Expect run mw.config.get('wgRevisionId') in browser console with second url return 911547240 instead of 0.

Event Timeline

Xiplus created this task.Sep 1 2019, 8:36 AM
Restricted Application added a project: Performance-Team. · View Herald TranscriptSep 1 2019, 8:36 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Krinkle added a subscriber: Krinkle.

This is not an issue with the mw.config system but rather with how the Diff system decides to export values to it. The values it exports are making it through without issue.

Krinkle removed a subscriber: Krinkle.Apr 7 2020, 6:49 PM